New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain menu commands are disabled after pasting a selection #275

Closed
aseprite-bot opened this Issue Aug 20, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@aseprite-bot

aseprite-bot commented Aug 20, 2014

From olsze...@gmail.com on October 17, 2013 16:42:09

What steps will reproduce the problem?

  1. Select part of the sprite using the rectangular marquee tool.
  2. Copy the selection (using Edit|Copy or by pressing Ctrl+C).
  3. Paste previously copied rectangle (through Edit|Paste or Ctrl+V).

What is the expected output? What do you see instead?
Menu commands like Edit|Flip Vertical or Edit|Flip Horizontal or even Edit|Paste should be active. Instead, they appear as disabled. However, they can be still accessed through keyboard shortcuts. What version of the product are you using? On what operating system? Aseprite 0.9.5 on Windows 8 64-bit.

Original issue: http://code.google.com/p/aseprite/issues/detail?id=275

@aseprite-bot

This comment has been minimized.

Show comment
Hide comment
@aseprite-bot

aseprite-bot Aug 20, 2014

From DocHoncho@gmail.com on November 28, 2013 22:06:39

Most items in Select are disabled as well.

I have looked a little bit into this problem, but not enough to say exactly what is causing it. I suspect it's the result of a disconnect between being a Selection and MovingPixels. For whatever reason when an image is pasted, it looks like there's a selection but it isn't really treated like one.

Status: Accepted

aseprite-bot commented Aug 20, 2014

From DocHoncho@gmail.com on November 28, 2013 22:06:39

Most items in Select are disabled as well.

I have looked a little bit into this problem, but not enough to say exactly what is causing it. I suspect it's the result of a disconnect between being a Selection and MovingPixels. For whatever reason when an image is pasted, it looks like there's a selection but it isn't really treated like one.

Status: Accepted

@aseprite-bot

This comment has been minimized.

Show comment
Hide comment
@aseprite-bot

aseprite-bot Aug 20, 2014

From davidcapello on November 30, 2013 13:49:24

This problem is because MovingPixelsState contains a PixelsMovement, which contains an UndoTransaction. This undo transaction lock the document in write mode in the whole transformation process of the pasted/moved image. It's quite hard to solve this. There are a "to do" item related with this which consist on adding undo to each transformation phase (e.g. you rotate, then scale, the move, there should be three different undo steps).

aseprite-bot commented Aug 20, 2014

From davidcapello on November 30, 2013 13:49:24

This problem is because MovingPixelsState contains a PixelsMovement, which contains an UndoTransaction. This undo transaction lock the document in write mode in the whole transformation process of the pasted/moved image. It's quite hard to solve this. There are a "to do" item related with this which consist on adding undo to each transformation phase (e.g. you rotate, then scale, the move, there should be three different undo steps).

@dacap dacap added this to the v1.1 milestone May 9, 2015

@dacap dacap added high priority and removed medium priority labels May 9, 2015

@dacap dacap self-assigned this Jun 2, 2015

dacap added a commit that referenced this issue Jun 2, 2015

Patch a possible crash when dropping pixels onBeforeFrameChanged
This is not a "real fix". But we hope the program at least doesn't crash
in this scenario.

Reviewed this problem on #275, #424, and #690

@dacap dacap closed this in 40394d9 Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment