Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a trackpad/mouse + stylus would zoom from the trackpad/mouse location instead of the stylus one #2783

Open
dacap opened this issue Jun 21, 2021 · 2 comments

Comments

@dacap
Copy link
Member

dacap commented Jun 21, 2021

Try to avoid using ui::get_mouse_position() (e.g. from ZoomCommand::onExecute), because it might use the invalid mouse position. Instead use the latest received mouse position in the Editor.

Probable related bug reports:

@dacap dacap added this to the v1.3-betas milestone Jun 21, 2021
@dacap dacap self-assigned this Jun 21, 2021
@dacap dacap modified the milestones: v1.3-betas, v1.3-beta5 Jun 22, 2021
@dacap dacap modified the milestones: v1.3-beta5, v1.3-beta6, v1.2.29 Jul 12, 2021
@dacap dacap added wip and removed wip labels Aug 3, 2021
@dacap dacap modified the milestones: v1.2.29, v1.3-beta6 Aug 3, 2021
@dacap
Copy link
Member Author

dacap commented Aug 9, 2021

On Windows ui::get_mouse_position already use an internal mouse position from the last mouse/pointer event (code), so the zoom issue is a problem because on Windows we receive the WM_MOUSEMOVE event from the trackpad position each 1 or 2 seconds (probably related to this).

Anyway there is a bug related to https://steamcommunity.com/app/431730/discussions/2/3059617763567164315/ where we cannot move our custom windows (e.g. the Preview window) with the stylus because we have to handle WM_NCPOINTERDOWN (instead of WM_NCLBUTTONDOWN).

@dacap
Copy link
Member Author

dacap commented Aug 12, 2021

aseprite/laf@d76cc1a

@dacap dacap modified the milestones: v1.3-beta6, v1.3-beta7 Aug 23, 2021
@dacap dacap modified the milestones: v1.3-beta7, v1.3-beta8 Oct 26, 2021
@dacap dacap modified the milestones: v1.3-beta8, v1.3-beta9 Jan 12, 2022
@dacap dacap modified the milestones: v1.3-beta12, v1.3-beta13 Mar 14, 2022
@dacap dacap modified the milestones: v1.3-beta15, v1.3.1 Jun 1, 2022
@dacap dacap removed their assignment Sep 15, 2022
@dacap dacap modified the milestones: v1.3.1, 1.3.2, v1.3.2, v1.3.3 Nov 28, 2023
@dacap dacap modified the milestones: v1.3.3, v1.3.4, v1.3.5 Feb 14, 2024
@dacap dacap modified the milestones: v1.3.5, v1.3.6 Feb 28, 2024
@dacap dacap modified the milestones: v1.3.6, v1.3.7 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant