Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash clicking combobox scrollbar quickly #2984

Closed
dacap opened this issue Oct 4, 2021 · 0 comments
Closed

Crash clicking combobox scrollbar quickly #2984

dacap opened this issue Oct 4, 2021 · 0 comments
Assignees
Labels
bug crash report Issue originated from a crash report / .dmp file critical priority
Milestone

Comments

@dacap
Copy link
Member

dacap commented Oct 4, 2021

On Aseprite v1.3-beta6 if we click the combobox scrollbar quickly we'll generate a crash because we access a deleted ui::Display* from a ui::Message:

 	Aseprite.exe!abort() Line 77	C++
 	[External Code]
>	Aseprite.exe!os::Window::pointToScreen(const gfx::PointT<int> & clientPosition) Line 34	C++
 	Aseprite.exe!ui::MouseMessage::screenPosition() Line 85	C++
 	Aseprite.exe!app::DynamicsPopup::onProcessMessage(ui::Message * msg) Line 480	C++
 	Aseprite.exe!ui::Widget::onProcessMessage(ui::Message * msg) Line 1539	C++
 	Aseprite.exe!ui::Widget::onProcessMessage(ui::Message * msg) Line 1539	C++
 	Aseprite.exe!ui::Widget::onProcessMessage(ui::Message * msg) Line 1539	C++
 	Aseprite.exe!ui::Widget::onProcessMessage(ui::Message * msg) Line 1539	C++
 	Aseprite.exe!ui::Manager::sendMessageToWidget(ui::Message * msg, ui::Widget * widget) Line 1916	C++
 	Aseprite.exe!ui::Manager::pumpQueue() Line 1778	C++
 	Aseprite.exe!ui::Manager::dispatchMessages() Line 834	C++
 	Aseprite.exe!ui::Manager::run() Line 291	C++
 	Aseprite.exe!app::App::run() Line 434	C++
 	Aseprite.exe!app_main(int argc, char * * argv) Line 105	C++
 	Aseprite.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpCmdLine, int nCmdShow) Line 41	C++

Reported:

@dacap dacap added bug critical priority crash report Issue originated from a crash report / .dmp file labels Oct 4, 2021
@dacap dacap added this to the v1.3-beta7 milestone Oct 4, 2021
@dacap dacap self-assigned this Oct 4, 2021
dacap added a commit that referenced this issue Oct 4, 2021
…cs popup (fix #2984)

We're trying to access the display() attribute of a kMouseDownMessage
message when the display was already deleted from Manager::_closeWindow.
@dacap dacap closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash report Issue originated from a crash report / .dmp file critical priority
Projects
None yet
Development

No branches or pull requests

1 participant