Skip to content

Crash closing a menubox with scrollbars #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sentry-io bot opened this issue Jan 14, 2022 · 0 comments
Closed

Crash closing a menubox with scrollbars #3132

sentry-io bot opened this issue Jan 14, 2022 · 0 comments

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 14, 2022

Sentry Issue: ASEPRITE-M

Only in beta version with multiple UI windows.

EXCEPTION_ACCESS_VIOLATION_READ: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ
  File "viewport.cpp", line 39, in ui::Viewport::onResize
    Point scroll = static_cast<View*>(parent())->viewScroll();
  File "widget.cpp", line 714, in ui::Widget::setBounds
    onResize(ev);
  File "rect.h", line 45, in gfx::RectT<T>::{ctor}
    w(rect.w), h(rect.h) {
  File "widget.cpp", line 714, in ui::Widget::setBounds
    onResize(ev);
  File "window.cpp", line 741, in ui::Window::windowSetPosition
    child->setBounds(cpos);
...
(15 additional frame(s) were not displayed)
@dacap dacap modified the milestones: v1.3, v1.3-beta9 Jan 14, 2022
dacap added a commit that referenced this issue Jan 14, 2022
Regression introduced in ed595eb
calling MenuBox::setMenu() of the first child of a MenuBoxWindow when
handling its kCloseMessage. The firstChild() was supposed to be a
MenuBox, but we didn't take care of the case when the MenuBox is
replaced with a View when scrollbars are needed (added by
add_scrollbars_if_needed()).
@dacap dacap closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant