Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in app::tools::BaseInk::prepareForPointShape #3338

Closed
sentry-io bot opened this issue May 26, 2022 · 3 comments
Closed

Crash in app::tools::BaseInk::prepareForPointShape #3338

sentry-io bot opened this issue May 26, 2022 · 3 comments
Assignees
Labels
bug crash report Issue originated from a crash report / .dmp file critical priority
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented May 26, 2022

Sentry Issue: ASEPRITE-8D

EXCEPTION_ACCESS_VIOLATION_READ / 0x0: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x0
  File "inks.h", line 36, in app::tools::BaseInk::prepareForPointShape
    m_proc->prepareForPointShape(loop, firstPoint, x, y);
  File "point_shapes.h", line 230, in app::tools::BrushPointShape::transformPoint
    ink->prepareForPointShape(loop, m_firstPoint, x, y);
  File "intertwiners.h", line 596, in app::tools::IntertwineAsPixelPerfect::doTransformPoint
    Intertwine::doTransformPoint(pt, loop);
  File "intertwine.cpp", line 85, in app::tools::Intertwine::doPointshapeStrokePt
    doTransformPoint(pt, loop);
  File "intertwiners.h", line 508, in app::tools::IntertwineAsPixelPerfect::joinStroke
    doPointshapeStrokePt(stroke[0], loop);
...
(26 additional frame(s) were not displayed)
@dacap dacap added the bug label May 26, 2022
@dacap dacap removed their assignment Sep 15, 2022
@sentry-io
Copy link
Author

sentry-io bot commented Apr 10, 2023

Sentry issue: ASEPRITE-K3

@dacap dacap added this to the v1.3-rc3 milestone Apr 17, 2023
@dacap dacap added critical priority crash report Issue originated from a crash report / .dmp file labels Apr 17, 2023
@dacap dacap modified the milestones: v1.3-rc3, v1.3-rc4 Apr 17, 2023
@dacap dacap moved this to Todo in Aseprite v1.3.x Apr 17, 2023
@dacap dacap self-assigned this May 1, 2023
@dacap dacap assigned martincapello and unassigned dacap May 9, 2023
martincapello added a commit to martincapello/aseprite that referenced this issue May 10, 2023
@martincapello
Copy link
Member

I was able to reproduce this by following these steps:

  1. Create a new "big" sprite (for instance 10000x10000 pixels).
  2. With the pencil tool draw some pixels.
  3. Hold down the "shift" key and begin clicking repeatedly while moving the mouse pointer in circles inside the zone marked in the following part of the screen:
    Screen Shot 2023-05-10 at 17 06 41

Note 1: It is important to move the mouse pointer to trigger the editor's automatic scroll behavior while in step 3.
Note 2: I was able to reproduce this once with a 128x128 sprite...but I couldn't do it again with this sprite size.

@martincapello
Copy link
Member

Reopening this because the proposed fix breaks several tools.

@martincapello martincapello removed the wip label May 15, 2023
martincapello added a commit to martincapello/aseprite that referenced this issue May 15, 2023
@dacap dacap closed this as completed in c902c56 May 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Aseprite v1.3.x May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment