Uninstalling (or updating) an extensions that has subdirectories results in an error

[thkwznk]

Uninstalling (or updating, I'm guessing it's an uninstall+install combo action) an extension that has subdirectories in its directory results in an error shown below.

It leaves the extension directory with empty subdirectories, there are zero files left.

Aseprite and System version

• Aseprite version: 1.2.35-x64
• System: Windows 11

[Gasparoken]

Thanks for this report @thkwznk. The closest attempt to reproduce this bug was when I added an additional folder inside an already installed extension folder, and then I tried to uninstall it.
As the new folder do not belongs to the extension file systm reported in "__info.json", Aseprite cannot remove it.

This makes me think that if an extension is capable of saving files inside the folder of the same extension, at the moment of uninstalling it -if it is not informed in "__info.json"- Aseprite will not be able to remove it.

Question: Does this happen with many extensions or just one in particular? Which?
EDIT: I was able to reproduce it a couple of times as you described (adding extra subdirectory inside of the extension folder). But other attempts, the directories are removed successfully (even with the extra subdirectory added). Anyway, if "__info.json" matches the subdirectory structure of the extension, all is well.

[dacap]

If I remember correctly the uninstalling logic of extension will try to delete all files from the __info.json file, but in that file directories are not listed, so yes, if there is a subdirectory in the extension, the files will be deleted but then the subdir will not. So I think there is a bug there 👍

[Gasparoken]

To stay on the same page: I guess the correct behavior is:

• Delete the original content of the extension
• Do not delete the files inside custom folders
• Unstalling will be successful, even with custom folders.
• Perhaps add an Alert "Warning: Custom folders were found which were not deleted."

@dacap correct me or add a comment if I'm wrong.

[dacap]

There shouldn't be any new alert. It's only a thing of deleting subdirectories after deleting all files listed in __info.json (when the files are being deleted, we can create a list of subdirectories, and then delete them).

[dacap]

I was able to reproduce it a couple of times as you described (adding extra subdirectory inside of the extension folder). But other attempts, the directories are removed successfully (even with the extra subdirectory added). Anyway, if "__info.json" matches the subdirectory structure of the extension, all is well.

In the past I think I was able to reproduce the problem without adding new files/subdirs manually after the installation. Now it looks like I cannot reproduce it, the only way to reproduce it is just adding new files/subdirs manually. In case someone has a test package to reproduce this with Install/Update without touching the installed folder manually, it would be great to attach it to a post here.

[thkwznk]

I just tried with extensions that produced this issue for me but all of them work correctly now in v1.2.39 and v1.3-beta20.

[Gasparoken]

I share the link to download the extension that I was testing to reproduce this error: https://community.aseprite.org/t/extension-animation-suite/13322 (nice extension @thkwznk 😄).
I was able to reproduce it by adding a new external folder within the extension's directory structure.

[Gasparoken]

@dacap something is to be fixed here?

As I said in the first reply:

Anyway, if "__info.json" matches the subdirectory structure of the extension, all is well.

But I found that if there is a new external folder present, the deletion of the directories will not complete (leaving empty folders as I said here). I think this PR solve this case as much as possible (leaving only the external folders intact).

[dacap]

I was able to reproduce it creating new empty dirs. And the PR fixes the error message, I think that is enough.