Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Tool & Change Tool (group) actions for Mouse Wheel are not working correctly on beta #3459

Closed
dacap opened this issue Aug 4, 2022 · 0 comments
Closed

Change Tool & Change Tool (group) actions for Mouse Wheel are not working correctly on beta #3459

dacap opened this issue Aug 4, 2022 · 0 comments
Assignees
@dacap
Labels
bug high priority
Milestone
v1.3-beta21

Comments

@dacap
Copy link
Member

dacap commented Aug 4, 2022

Since the introduction of the "Drag Value", the actions Change Tool and Change Tool (group) with Mouse Wheel + a key modifier are not working on the beta version.
@dacap dacap added this to the v1.3.0 milestone Aug 4, 2022
@dacap dacap self-assigned this Aug 4, 2022
dacap added a commit that referenced this issue Aug 8, 2022
@dacap
Fix WheelAction::ToolSameGroup/ToolOtherGroup in DraggingValueState (fix
854bb2e 
 #3459)

These actions weren't working correctly because we have to take
special care when we change the tool group, i.e. the "initial
position" used to calculate the delta from "mouse pos - initial pos"
must be updated to reset the delta to change tools inside the same
tool (this is the new m_initialPosSameGroup member variable).
@dacap dacap closed this as completed Aug 8, 2022
@dacap dacap removed the wip label Aug 9, 2022
@dacap dacap modified the milestones: v1.3.0, v1.3-beta21 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
bug high priority
Projects
None yet
Milestone
v1.3-beta21
Development

No branches or pull requests
1 participant
@dacap