Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in ui::Manager::_closeWindow #3491

Closed
sentry-io bot opened this issue Aug 29, 2022 · 0 comments
Closed

Crash in ui::Manager::_closeWindow #3491

sentry-io bot opened this issue Aug 29, 2022 · 0 comments
Assignees
Labels
bug crash report Issue originated from a crash report / .dmp file time-2
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Aug 29, 2022

Sentry Issue: ASEPRITE-3R

EXCEPTION_ACCESS_VIOLATION_READ / 0x4d00000038: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x4d00000038
  File "manager.cpp", line 1520, in ui::Manager::_closeWindow
    const int scale = parentNativeWindow->scale();
  File "window.cpp", line 419, in ui::Window::closeWindow
    man->_closeWindow(this, true);
  File "preview_editor.cpp", line 352, in app::PreviewEditorWindow::updateUsingEditor
    hideWindow();
  File "ui_context.cpp", line 116, in app::UIContext::setActiveView
    mainWin->getPreviewEditor()->updateUsingEditor(current_editor);
  File "functional", line 880, in std::_Func_class<T>::operator()
    return _Impl->_Do_call(_STD forward<_Types>(_Args)...);
...
(32 additional frame(s) were not displayed)
@dacap dacap added bug crash report Issue originated from a crash report / .dmp file time-2 labels Aug 29, 2022
@dacap dacap added this to the v1.3.0 milestone Aug 29, 2022
dacap added a commit to dacap/aseprite that referenced this issue Aug 29, 2022
We can reproduce the bug (without this patch) pressing Ctrl+S to save
the active sprite and clicking randomly in the menu bar (File, Edit,
etc. options) to open other menu boxes (a crash can happen when
multiple windows UI is enabled).
dacap added a commit to dacap/aseprite that referenced this issue Aug 29, 2022
…rite#3491, fix aseprite#2907)

This might be a fix for two frequently reported crashes from Sentry:

1) In Manager::_closeWindow() (aseprite#3491): We can reproduce this bug (without
this patch) pressing Ctrl+S to save the active sprite and clicking
randomly in the menu bar (File, Edit, etc. options) to open other menu
boxes (a crash can happen when multiple windows UI is enabled).

2) In set_native_cursor_on_all_displays() (aseprite#2907): We weren't able to
reproduce this bug.
@dacap dacap closed this as completed Aug 29, 2022
@dacap dacap modified the milestones: v1.3.0, v1.3-beta21 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash report Issue originated from a crash report / .dmp file time-2
Projects
None yet
Development

No branches or pull requests

1 participant