Skip to content

Crash in ui::View::getView #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sentry-io bot opened this issue Sep 5, 2022 · 1 comment
Closed

Crash in ui::View::getView #3504

sentry-io bot opened this issue Sep 5, 2022 · 1 comment
Assignees
@dacap
Labels
bug crash report Issue originated from a crash report / .dmp file
Milestone
v1.3-rc1

Comments

@sentry-io
Copy link

sentry-io bot commented Sep 5, 2022

Sentry Issue: ASEPRITE-GR

EXCEPTION_ACCESS_VIOLATION_READ / 0x180: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x180
  File "view.cpp", line 205, in ui::View::getView
    (widget->parent()->parent()) &&
  File "recent_listbox.cpp", line 210, in app::RecentFileItem::pinBounds
    ui::View* view = View::getView(parent());
  File "recent_listbox.cpp", line 208, in app::RecentFileItem::pinBounds
    auto theme = SkinTheme::get(this);
  File "recent_listbox.cpp", line 156, in app::RecentFileItem::onPaint
    const gfx::Rect pinBounds = this->pinBounds(bounds);
  File "widget.cpp", line 1159, in ui::Widget::paintEvent
    onPaint(ev); // Fire onPaint event
...
(12 additional frame(s) were not displayed)
@dacap dacap added bug crash report Issue originated from a crash report / .dmp file labels Sep 5, 2022
@dacap dacap added this to the v1.2.41 milestone Sep 5, 2022
@dacap dacap self-assigned this Nov 3, 2022
@sentry-io
Copy link
Author

sentry-io bot commented Nov 3, 2022

Sentry issue: ASEPRITE-PN

@dacap dacap added the wip label Nov 7, 2022
@dacap dacap modified the milestones: v1.2.41, v1.3.0 Nov 8, 2022
dacap added a commit to dacap/aseprite that referenced this issue Nov 9, 2022
@dacap
Fix possible crash calling View::getView() with a nullptr widget (ase…
4643aa6 
…prite#3504)
dacap added a commit to dacap/aseprite that referenced this issue Nov 9, 2022
@dacap
Destroy overlay in ~DraggableWidget destructor
551aae3 
There is an issue where we can drag a recent item and load a file
(using Alt+F or Ctrl+O) while dragging the recent item. With this
commit the overlay is destroyed after the file is open (without this
the overlay is kept floating).

Probably related to aseprite#3504 but we're not sure.
@dacap dacap removed the wip label Nov 9, 2022
@dacap dacap removed their assignment Nov 9, 2022
@dacap dacap self-assigned this Feb 20, 2023
@dacap dacap closed this as completed Feb 20, 2023
dacap added a commit that referenced this issue Mar 4, 2023
@dacap
Fix crash/assert painting a RecentFileItem (or any ui::Widget) withou…
2321311 
…t parents (fix #3504)

We were finally able to reproduce #3504 (an assert fail) and it looks
like a bug in the Widget::removeChild() function, where kPaintMessage
messages weren't removed from the queue after the widget is removed
from its parent.
@aseprite aseprite deleted a comment from Kylemclean11 May 11, 2023
@dacap dacap mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dacap dacap

Labels
bug crash report Issue originated from a crash report / .dmp file
Projects
None yet
Milestone
v1.3-rc1
Development

No branches or pull requests
1 participant
@dacap