Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8 Connected Fill Escapes Grid With "Stop At Grid" Checked #3564

Closed
KasumiArai opened this issue Oct 20, 2022 · 1 comment
Closed

8 Connected Fill Escapes Grid With "Stop At Grid" Checked #3564

KasumiArai opened this issue Oct 20, 2022 · 1 comment
Assignees
@Gasparoken
Labels
bug high priority time-3
Milestone
v1.3-rc2

Comments

@KasumiArai
Copy link

Select the Fill Tool.
Turn on 8 Connected Fill and Stop at Grid for the fill tool.
Turn on the grid.
Occasionally filling will escape the grid.
8 Connected Fill

Aseprite v1.3-beta21-x64 Steam
Windows 10
@Gasparoken
Copy link
Member

Thank you for this report. You're right! This happens in the stable version too.

@Gasparoken Gasparoken added this to the v1.2-stable milestone Oct 20, 2022
@Gasparoken Gasparoken self-assigned this Oct 20, 2022
@Gasparoken Gasparoken added the wip label Oct 20, 2022
Gasparoken added a commit that referenced this issue Oct 22, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
ac11404 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
@Gasparoken Gasparoken linked a pull request Oct 22, 2022 that will close this issue
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564) #3566
Closed
@Gasparoken Gasparoken removed the wip label Oct 22, 2022
dacap pushed a commit that referenced this issue Nov 16, 2022
@Gasparoken @dacap
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
8a10a38 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
@dacap dacap modified the milestones: v1.2-stable, v1.3.0 Nov 16, 2022
Gasparoken added a commit that referenced this issue Nov 23, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
7f6cc63 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
@Gasparoken Gasparoken mentioned this issue Nov 23, 2022
Closed
Gasparoken added a commit that referenced this issue Nov 23, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
fb0a458 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
Gasparoken added a commit that referenced this issue Nov 23, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
124afcd 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
Gasparoken added a commit that referenced this issue Nov 25, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
36c4314 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
Gasparoken added a commit that referenced this issue Nov 25, 2022
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
25fce1d 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
Gasparoken added a commit that referenced this issue Feb 22, 2023
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
71fb8de 
)

Prior to this fix with the setting: '8-Connected' + 'Stop at Grid', the 'Paint Bucket' and 'Magic Wand' tools went through the grid on the left side.
Tests added.
fix #3564
Gasparoken added a commit that referenced this issue Feb 22, 2023
@Gasparoken
Fix 8 Connected Fill escapes grid with "Stop At Grid" checked (fix #3564
72fffb3 
)
@dacap dacap modified the milestones: v1.3-rc1, v1.3.1 Mar 1, 2023
@dacap dacap modified the milestones: v1.3.1, v1.3-rc2 Mar 28, 2023
@dacap dacap closed this as completed in 8f515da Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gasparoken Gasparoken

Labels
bug high priority time-3
Projects
None yet
Milestone
v1.3-rc2
3 participants
@dacap @KasumiArai @Gasparoken