Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set of properties to doc::UserData #3631

Closed
dacap opened this issue Dec 16, 2022 · 1 comment
Closed

Add set of properties to doc::UserData #3631

dacap opened this issue Dec 16, 2022 · 1 comment
Assignees
Labels
feature Feature request, or something should be improved maintenance

Comments

@dacap
Copy link
Member

dacap commented Dec 16, 2022

Related to #3625

Add a set of sets of typed-properties (including points) to doc::UserData depending on extension ID (empty ID are user-defined properties, just like the current user data field).
Something like

std::map<std::string, std::map<std::string, std::any>> m_properties;

or

std::map<std::string, std::map<std::string, Variant>> m_properties;

?
Where Variant = std::variant<bool, int, std::string, gfx::Point, etc….> (these types will be limited to the .aseprite format, and probably will not be possible to extend it after the initial set of types)

@dacap dacap converted this from a draft issue Dec 16, 2022
@dacap dacap added the feature Feature request, or something should be improved label Dec 16, 2022
@martincapello martincapello moved this from Todo to In Progress in Attachment System Dec 19, 2022
@dacap
Copy link
Member Author

dacap commented Dec 26, 2022

@martincapello probably this issue is more important than the serialization first so the Lua API can be implemented (not sure if it does make sense to just push a first PR with just this change and then do an intensive test of .aseprite changes with automatic tests/etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, or something should be improved maintenance
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants