Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush preview issues entering on Drag Value #3884

Closed
Gasparoken opened this issue May 18, 2023 · 1 comment
Closed

Brush preview issues entering on Drag Value #3884

Gasparoken opened this issue May 18, 2023 · 1 comment
Assignees
@Gasparoken
Labels
bug high priority time-3
Milestone
v1.3-rc5

Comments

@Gasparoken
Copy link
Member

Gasparoken commented May 18, 2023 •
edited
Loading

Some times in certain conditions the edge preview of the erase tool is printed on the viewport just pressing Control+Option. This problem is just visual, no sprite modifications are done.

Steps to reproduce:

  • New Sprite 200x200
  • 100% zoom
  • New Sprite 200x200
  • 3200% zoom
  • Pincel tool
  • Press 'control' and hold + 'Alt' and hold (entering to dragging value to modify brush size).
  • Result: the brush preview doesn't show:
Screen.Recording.2023-05-18.at.15.15.15.mov

Aseprite and System version

  • Aseprite version: 1.3rc4
  • System: macOS Ventura
@Gasparoken Gasparoken added this to the v1.3-rc5 milestone May 18, 2023
@Gasparoken Gasparoken moved this to Todo in Aseprite v1.3.x May 22, 2023
@Gasparoken Gasparoken self-assigned this May 24, 2023
@Gasparoken Gasparoken moved this from Todo to In Progress in Aseprite v1.3.x May 24, 2023
@Gasparoken Gasparoken moved this from In Progress to Todo in Aseprite v1.3.x May 24, 2023
@Gasparoken Gasparoken moved this from Todo to In Progress in Aseprite v1.3.x May 24, 2023
@Gasparoken
Copy link
Member Author

Gasparoken commented May 31, 2023 •
edited
Loading

Some progress:
This issue happens when the editor has at least 2 opened documents (Sprite-01 and Sprite-02 for example) and the active one is the Sprite-02 + some "quick tool" (as eyedropper (Alt), or move tool (Cmd), or Hand tool (Space bar)) is activated just pressing and releasing.
When the mentioned conditions are meet, the current viewport still shows the Sprite-02, but internally some member variables of 'editor' corresponds to Sprite-01 (as m_document or m_proj). This mix can make several unexpected behaviors.
I'm still looking for the source of the error.

Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 2, 2023
@Gasparoken
Fix unnecessary propagation of onProcessMessage across all open edito…
57a2b40 
…rs in kKeyDownMessage cases

The pressed key should work only in the active editor.
Also this fix solves ‘Brush preview issues entering on Drag Value aseprite#3884’
@Gasparoken Gasparoken mentioned this issue Jun 2, 2023
Closed
@Gasparoken Gasparoken moved this from In Progress to Done in Aseprite v1.3.x Jun 2, 2023
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 2, 2023
@Gasparoken
Fix unnecessary propagation of onProcessMessage across all open edito…
637c7df 
…rs in kKeyDownMessage cases

The pressed key should be transmitted to the active editor or the one the mouse is over.
Also this fix solves ‘Brush preview issues entering on Drag Value aseprite#3884’
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 5, 2023
@Gasparoken
Fix unnecessary propagation of onProcessMessage across all open edito…
1975527 
…rs in kKeyDownMessage and kKeyUpMessage cases

The pressed key should be transmitted to the active editor or the one the mouse is over.
Also this fix solves ‘Brush preview issues entering on Drag Value aseprite#3884’
@dacap dacap closed this as completed in a628bbb Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gasparoken Gasparoken

Labels
bug high priority time-3
Projects
Aseprite v1.3.x
Archived in project
Milestone
v1.3-rc5
1 participant
@Gasparoken