Skip to content

Unexpected behavior during multiple cel selection + Cel Properties changes #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gasparoken opened this issue May 18, 2023 · 2 comments · Fixed by #3892
Closed

Unexpected behavior during multiple cel selection + Cel Properties changes #3886

Gasparoken opened this issue May 18, 2023 · 2 comments · Fixed by #3892

Comments

@Gasparoken
Copy link
Member

Issue 1:

  • New Sprite
  • Add a couple of frames.
  • Draw something on frame 2
  • Delete the cel on frame 1
  • Double click on cel of frame 2 to open Cel Properties, don't close it.
  • Select the cel range 1 to 3
  • On Cel Properties modify the Color or Z-index or User data.
  • Select the cel 2 (non-empty cel).
  • Result: the properties were not modified. Expected: the modified fields would be modified in the non-empty cel.

Issue 2: unmodified fields are overwritten.

  • New Sprite
  • Add a couple of frames.
  • Draw something on frame 1 and 2
  • Double click on cel of frame 1 to open Cel Properties, don't close it.
  • Add some user data for example "first frame"
  • Select the cel range 1 to 3
  • On Cel Properties modify just the Color.
  • Select the cel 1 (non-empty cel).
  • Result: user data was modified in all cels. Expected: Modify only cel colors. User data must be kept intact

Aseprite and System version

  • Aseprite version: 1.3rc4
  • System: macOS Ventura
@Gasparoken Gasparoken added this to the v1.3-rc5 milestone May 18, 2023
@Gasparoken Gasparoken self-assigned this May 22, 2023
@Gasparoken Gasparoken added wip and removed wip labels May 22, 2023
@Gasparoken Gasparoken moved this to In Progress in Aseprite v1.3.x May 22, 2023
Gasparoken added a commit that referenced this issue May 22, 2023
…y changes (fix #3886)

Prior to this fix, if a field was modified, all fields were overwritten with the values from the Cel Properties dialog.
Gasparoken added a commit that referenced this issue May 22, 2023
… changes (fix #3886)

Prior to this fix, if a field was modified, all fields were overwritten with the values from the Cel Properties dialog.
Gasparoken added a commit that referenced this issue May 22, 2023
…changes (fix #3886)

Prior to this fix, if a field was modified, all fields were overwritten with the values from the Cel Properties dialog.
@Gasparoken Gasparoken moved this from In Progress to Done in Aseprite v1.3.x May 22, 2023
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue May 22, 2023
…changes (fix aseprite#3886)

Prior to this fix, if a field was modified, all fields were overwritten with the values from the Cel Properties dialog.
@shanianickel
Copy link

I have a related problem where altering the Z-index with a bunch of cels in a selection also updates all of their color data, which is not my intention.
Does the linked fix also prevent this situation from happening?
Aseprite_eDLkkWLFpc

@dacap
Copy link
Member

dacap commented Jul 18, 2023

That's right @shanianickel, it's related to this issue. We'll merge the fix for the next release.

dacap pushed a commit that referenced this issue Jul 18, 2023
…changes (fix #3886)

Prior to this fix, if a field was modified, all fields were overwritten with the values from the Cel Properties dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment