Skip to content

Crash when loading an extension with invalid dithering matrices (?) and the console must be shown #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sentry-io bot opened this issue Jun 5, 2023 · 0 comments
Assignees
Labels
bug crash report Issue originated from a crash report / .dmp file
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 5, 2023

Sentry Issue: ASEPRITE-14T

OS Version: Windows 10.0.19045 (2965)
Report Version: 104

Crashed Thread: 23012

Application Specific Information:
Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x280

Thread 23012 Crashed:
0   aseprite.exe                    0x7ff614f4189e      mtx_do_lock (mutex.cpp:88)
1   aseprite.exe                    0x7ff6148f5f81      [inlined] std::_Mutex_base::lock (mutex:50)
2   aseprite.exe                    0x7ff6148f5f81      [inlined] std::lock_guard<T>::{ctor} (mutex:427)
3   aseprite.exe                    0x7ff6148f5f81      [inlined] obs::safe_list<T>::push_back (safe_list.h:293)
4   aseprite.exe                    0x7ff6148f5f81      obs::signal<T>::add_slot (signal.h:98)
5   aseprite.exe                    0x7ff6148f5394      [inlined] obs::signal<T>::connect (signal.h:104)
6   aseprite.exe                    0x7ff6148f5394      app::Console::ConsoleWindow::ConsoleWindow (console.cpp:49)
7   aseprite.exe                    0x7ff6148f5178      app::Console::Console (console.cpp:225)
8   aseprite.exe                    0x7ff61499980c      app::load_document (file.cpp:219)
9   aseprite.exe                    0x7ff614b0c1b3      app::load_dithering_matrix_from_sprite (load_matrix.cpp:26)
10  aseprite.exe                    0x7ff61490e31b      app::Extension::DitheringMatrixInfo::matrix (extensions.cpp:223)
11  aseprite.exe                    0x7ff614c3b1bd      app::DitheringSelector::regenerate (dithering_selector.cpp:235)
12  aseprite.exe                    0x7ff614c3a3af      app::DitheringSelector::DitheringSelector (dithering_selector.cpp:190)
13  aseprite.exe                    0x7ff614b4c147      app::ContextBar::ContextBar (context_bar.cpp:1762)
14  aseprite.exe                    0x7ff614974e88      app::MainWindow::MainWindow (main_window.cpp:109)
15  aseprite.exe                    0x7ff6148698d7      app::App::initialize (app.cpp:365)
16  aseprite.exe                    0x7ff61486238a      app_main (main.cpp:143)
17  aseprite.exe                    0x7ff614ffe635      wWinMain (main.cpp:40)
18  aseprite.exe                    0x7ff614f72b29      [inlined] invoke_main (exe_common.inl:118)
19  aseprite.exe                    0x7ff614f72b29      __scrt_common_main_seh (exe_common.inl:288)
20  KERNEL32.DLL                    0x7ffabee87613      BaseThreadInitThunk
21  ntdll.dll                       0x7ffac09c26a0      RtlUserThreadStart
@dacap dacap added bug crash report Issue originated from a crash report / .dmp file labels Jun 5, 2023
@dacap dacap added this to the v1.3-rc5 milestone Jun 5, 2023
@dacap dacap moved this to Todo in Aseprite v1.3.x Jun 5, 2023
@Gasparoken Gasparoken moved this from Todo to In Progress in Aseprite v1.3.x Jun 7, 2023
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 9, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
@Gasparoken Gasparoken moved this from In Progress to Done in Aseprite v1.3.x Jun 9, 2023
@Gasparoken Gasparoken moved this from Done to In Progress in Aseprite v1.3.x Jun 16, 2023
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 16, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
@Gasparoken Gasparoken moved this from In Progress to Done in Aseprite v1.3.x Jun 16, 2023
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 21, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 21, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 26, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 26, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 26, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 26, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 26, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Jun 27, 2023
…nd the console must be shown (fix aseprite#3914)

Before this fix, when installing dithering matrices if Aseprite couldn't find the file of some matrix described in the json, Aseprite would crash (this happened during the installation of an erroneous dithering matrices extension, and after every reboot of Aseprite).
The cause of the crash was the absence of the MainWindow instance during the ContextBar creation. When an error occurs, the console is called, but since MainWindows is not yet available, aseprite crashes.
@dacap dacap closed this as completed in f7bc918 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash report Issue originated from a crash report / .dmp file
Projects
Archived in project
2 participants