Crash rendering image/renderPlan

[sentry]

Sentry Issue: ASEPRITE-1XF

EXCEPTION_ACCESS_VIOLATION_READ / 0x2a2108dfc80: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0x2a2108dfc80
  File "image_impl.h", line 51, in doc::ImageImpl<T>::address
    return (address_t)(getLineAddress(y) + x);
  File "primitives_fast.h", line 24, in doc::get_pixel_address_fast
    return (((ImageImpl<Traits>*)image)->address(x, y));
  File "image_iterator.h", line 105, in doc::ImageIteratorT<T>::operator++
    m_ptr = get_pixel_address_fast<ImageTraits>(m_image, m_x, m_y);
  File "render.cpp", line 198, in render::`anonymous namespace'::composite_image_without_scale<T>
    ++src_it;
  File "render.cpp", line 1440, in render::Render::renderImage
    compositeImage(
...
(34 additional frame(s) were not displayed)

[dacap]

I think https://igara-studio.sentry.io/share/issue/9db0aa6f544e4f7b867073e3d9bd75d4/ is related to this one too.

[dacap]

Probably related to #4316 (which is not full-fixed yet). Probably it's better to wait for a next version with a new fix for #4316 before to look to this crash (as all might be related).

[martincapello]

I've been looking this crash a bit...and there is something weird (at least for me, maybe it is not weird at all at the end). As far as I understand the stack trace showed by Sentry is about calls happening in the main thread...when I tried to reproduce the crash while running in debug mode this is the stack trace of the main thread I've got:

aseprite.exe!render::`anonymous namespace'::composite_image_without_scale<doc::RgbTraits,doc::RgbTraits>(doc::Image * dst, const doc::Image * src, const doc::Palette * pal, const gfx::ClipT<double> & areaF, const int opacity, const doc::BlendMode blendMode, const double sx, const double sy, const bool newBlend, const unsigned int __formal) Line 198	C++
 	aseprite.exe!render::Render::renderImage(doc::Image * dst_image, const doc::Image * cel_image, const doc::Palette * pal, const gfx::RectT<double> & celBounds, const gfx::ClipT<int> & area, void(*)(doc::Image *, const doc::Image *, const doc::Palette *, const gfx::ClipT<double> &, const int, const doc::BlendMode, const double, const double, const bool, const unsigned int) compositeImage, const int opacity, const doc::BlendMode blendMode, const unsigned int tileFlags) Line 1455	C++
 	aseprite.exe!render::Render::renderCel(doc::Image * dst_image, const doc::Cel * cel, const doc::Image * cel_image, const doc::Layer * cel_layer, const doc::Palette * pal, const gfx::RectT<double> & celBounds, const gfx::ClipT<int> & area, void(*)(doc::Image *, const doc::Image *, const doc::Palette *, const gfx::ClipT<double> &, const int, const doc::BlendMode, const double, const double, const bool, const unsigned int) compositeImage, const int opacity, const doc::BlendMode blendMode) Line 1414	C++
 	aseprite.exe!render::Render::renderPlan(doc::RenderPlan & plan, doc::Image * image, const gfx::ClipT<int> & area, const int frame, void(*)(doc::Image *, const doc::Image *, const doc::Palette *, const gfx::ClipT<double> &, const int, const doc::BlendMode, const double, const double, const bool, const unsigned int) compositeImage, const bool render_background, const bool render_transparent, const doc::BlendMode blendMode) Line 1243	C++
 	aseprite.exe!render::Render::renderSpriteLayers(doc::Image * dstImage, const gfx::ClipT<double> & area, int frame, void(*)(doc::Image *, const doc::Image *, const doc::Palette *, const gfx::ClipT<double> &, const int, const doc::BlendMode, const double, const double, const bool, const unsigned int) compositeImage) Line 901	C++
 	aseprite.exe!render::Render::renderSprite(doc::Image * dstImage, const doc::Sprite * sprite, int frame, const gfx::ClipT<double> & area) Line 836	C++
 	aseprite.exe!app::SimpleRenderer::renderSprite(os::Surface * dstSurface, const doc::Sprite * sprite, const int frame, const gfx::ClipT<double> & area) Line 107	C++
 	aseprite.exe!app::EditorRender::renderSprite(os::Surface * dstSurface, const doc::Sprite * sprite, int frame, const gfx::ClipT<double> & area) Line 186	C++
 	aseprite.exe!app::Editor::drawOneSpriteUnclippedRect(ui::Graphics * g, const gfx::RectT<int> & spriteRectToDraw, int dx, int dy) Line 745	C++
 	aseprite.exe!app::Editor::drawSpriteUnclippedRect(ui::Graphics * g, const gfx::RectT<int> & _rc) Line 897	C++
 	aseprite.exe!app::Editor::onPaint(ui::PaintEvent & ev) Line 2271	C++
 	aseprite.exe!ui::Widget::paintEvent(ui::Graphics * graphics, const bool isBg) Line 1234	C++
 	aseprite.exe!ui::Widget::onProcessMessage(ui::Message * msg) Line 1574	C++
 	aseprite.exe!app::Editor::onProcessMessage(ui::Message * msg) Line 2165	C++
 	aseprite.exe!app::`anonymous namespace'::AppEditor::onProcessMessage(ui::Message * msg) Line 167	C++
 	aseprite.exe!ui::Widget::sendMessage(ui::Message * msg) Line 1341	C++
 	aseprite.exe!ui::Manager::sendMessageToWidget(ui::Message * msg, ui::Widget * widget) Line 2011	C++
 	aseprite.exe!ui::Manager::pumpQueue() Line 1897	C++
 	aseprite.exe!ui::Manager::dispatchMessages() Line 884	C++
 	aseprite.exe!ui::MessageLoop::pumpMessages() Line 27	C++
 	aseprite.exe!ui::Manager::run() Line 292	C++
 	aseprite.exe!app::App::run() Line 563	C++
 	aseprite.exe!app_main(int argc, char * * argv) Line 156	C++
 	aseprite.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpCmdLine, int nCmdShow) Line 41	C++

This is the first call to composite_image_without_scale after the SpriteSizeCommand invocation. It is missing the app::SpriteSizeCommand::onExecute (cmd_sprite_size.cpp:465)along several other parts of the stack trace that Sentry reported. Feels like some kind of threading issue or something..I'm not sure yet.