New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetry axis handles disappear as you zoom in #873

Closed
ghost opened this Issue Nov 24, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Nov 24, 2015

A possible solution is to stick them to viewport borders.

@dacap dacap added the enhancement label Nov 24, 2015

@dacap dacap added this to the v1.1 milestone Nov 24, 2015

@TheKK

This comment has been minimized.

Show comment
Hide comment
@TheKK

TheKK Dec 5, 2015

Contributor

Hi, @JPNK
Could you help me checking if this problem still exist? If so, could you please describe how to reproduce. Thanks :)

Contributor

TheKK commented Dec 5, 2015

Hi, @JPNK
Could you help me checking if this problem still exist? If so, could you please describe how to reproduce. Thanks :)

@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Dec 5, 2015

Member

Hi @TheKK, the problem is still present in master branch. Symmetry handles are not visible when the sprite is bigger than the viewport (e.g. you zoom in). A possible solution as @JPNK said is to keep symmetry handles in the viewport boundaries. (It shouldn't be so hard to fix this issue modifying StandbyState::Decorator::getSymmetryHandles.)

Member

dacap commented Dec 5, 2015

Hi @TheKK, the problem is still present in master branch. Symmetry handles are not visible when the sprite is bigger than the viewport (e.g. you zoom in). A possible solution as @JPNK said is to keep symmetry handles in the viewport boundaries. (It shouldn't be so hard to fix this issue modifying StandbyState::Decorator::getSymmetryHandles.)

@TheKK

This comment has been minimized.

Show comment
Hide comment
@TheKK

TheKK Dec 6, 2015

Contributor

I gave this a try. The logical part is quite simple (2537b76), but unexpected behaviour from app::Editor::setEditorScroll stuck with me.

untitled

This is what we'll get If we do scrolling via app::Editor::setEditorScroll with argument blitValidRegion as true (I guess this is for performance optimization). Since I'm still not familiar with the architecture and design of aseprite, I think I'll need your advice to solve this, @dacap.

Btw, this glitch happened if we scroll by:

  • Drag with mouse middle button
  • Hand tool
  • Space + ArrayKey shortcut

not happened by:

  • drag the scroll bars of editor view (because it call ui::View::setViewScroll directly)
Contributor

TheKK commented Dec 6, 2015

I gave this a try. The logical part is quite simple (2537b76), but unexpected behaviour from app::Editor::setEditorScroll stuck with me.

untitled

This is what we'll get If we do scrolling via app::Editor::setEditorScroll with argument blitValidRegion as true (I guess this is for performance optimization). Since I'm still not familiar with the architecture and design of aseprite, I think I'll need your advice to solve this, @dacap.

Btw, this glitch happened if we scroll by:

  • Drag with mouse middle button
  • Hand tool
  • Space + ArrayKey shortcut

not happened by:

  • drag the scroll bars of editor view (because it call ui::View::setViewScroll directly)
@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Dec 7, 2015

Member

@TheKK the issue is tricky. I was testing and the problem is that symmetry handles move along the scroll (their position changes when the scroll changes). It's a situation that isn't found in other Editor's states. I was trying to fix this problem but I'll need more time.

Member

dacap commented Dec 7, 2015

@TheKK the issue is tricky. I was testing and the problem is that symmetry handles move along the scroll (their position changes when the scroll changes). It's a situation that isn't found in other Editor's states. I was trying to fix this problem but I'll need more time.

@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Dec 7, 2015

Member

@TheKK now you can create a PR to fix this issue, the commit 562106c fix the scroll issue

Member

dacap commented Dec 7, 2015

@TheKK now you can create a PR to fix this issue, the commit 562106c fix the scroll issue

@TheKK

This comment has been minimized.

Show comment
Hide comment
@TheKK

TheKK Dec 8, 2015

Contributor

Thanks for your help, @dacap. I'll take a look inside your commit and see what's going on exactly.

Contributor

TheKK commented Dec 8, 2015

Thanks for your help, @dacap. I'll take a look inside your commit and see what's going on exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment