Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop mnenomic processing from truncating multibyte characters #1661

merged 2 commits into from Feb 22, 2018


Copy link

@yuxshao yuxshao commented Feb 13, 2018

Addresses #1660 though I'm not sure if it's the cleanest/most obvious way...

newText.push_back(*it) used to push each subsequent symbol casted to a char even if it was multibyte. This is avoided by initializing newText as a std::wstring and converting to std::string when setting widget text.

Looks like this on my machine now:
Not sure what might be a good way to make a little sharper. Would an extension to pixel fonts for other character sets be a reasonable idea? (or was this behaviour intentional so that widgets only have ASCII text?)

Thanks for the awesome software by the way :)

Copy link

@dacap dacap commented Feb 14, 2018

Thanks @yuxshao for this fix, I'll give a try and merge the PR soon.

@dacap dacap self-assigned this Feb 14, 2018
@dacap dacap added this to the v1.2 milestone Feb 14, 2018
@yuxshao yuxshao force-pushed the yuxshao:multibyte-char-fix branch to 7fb0334 Feb 15, 2018
@yuxshao yuxshao force-pushed the yuxshao:multibyte-char-fix branch to 6d5510d Feb 15, 2018
@dacap dacap merged commit afdb6d2 into aseprite:master Feb 22, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Copy link

@dacap dacap commented Feb 22, 2018

@yuxshao I've just merged the PR, thanks for the patch!

@yuxshao yuxshao deleted the yuxshao:multibyte-char-fix branch Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants