New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TGA v2.0 footer in TGA type file on export #1946

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@rajivmg
Copy link

rajivmg commented Dec 8, 2018

Save exported TGA file as v2.0 TGA file by appending TGA v2.0 footer at the end of the file as recommended by following:

  1. http://www.dca.fee.unicamp.br/~martino/disciplinas/ea978/tgaffs.pdf
  2. http://netghost.narod.ru/gff/graphics/summary/tga.htm

This was causing issue (bjorn/tiled#2013) when trying to load .TGA file exported from Aseprite into Tiled Map Editor (https://www.mapeditor.org/) because it uses QT library to load images, and QT doesn't support non-TrueVision 2.0 files (https://code.woboq.org/qt5/qtimageformats/src/plugins/imageformats/tga/qtgafile.cpp.html#186)

TGA v2.0 format is backward compatible and it doesn't affect applications that expect original TGA format file.

I have tested the fix myself, it fixes the issue (bjorn/tiled#2013) and everything else is working as expected.

@dacap

This comment has been minimized.

Copy link
Member

dacap commented Dec 9, 2018

Thanks @rajivmg, I'll merge this one tomorrow and I guess it will be available in 1.2.10-beta4 (which must be released next week because some regressions in beta3).

@dacap dacap self-assigned this Dec 9, 2018

@dacap dacap added this to the v1.2 milestone Dec 9, 2018

@dacap dacap merged commit 0203b65 into aseprite:master Dec 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rajivmg rajivmg deleted the rajivmg:fix-tga2 branch Dec 16, 2018

@rajivmg rajivmg restored the rajivmg:fix-tga2 branch Dec 16, 2018

@rajivmg rajivmg deleted the rajivmg:fix-tga2 branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment