Implements 'trim-by-grid' CL option #2010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacap
reviewed
Feb 12, 2019
| else if (opt == &m_options.trimByGrid()) { | ||
| cof.trimByGrid = true; | ||
| if (m_exporter) | ||
| m_exporter->setTrimByGrid(true); |
There was a problem hiding this comment.
As we talked in the email, I think here we can call m_exporter->setTrimCels(true); too.
|
Please try to use commit -amend and push -force to make easier the merge and avoid a lot of little commits. Please also give you a time for testing. |
dncampo
force-pushed
the
trim-by-grid-CLI
branch
from
b761e3f
to
5e132c4
Compare
dacap
reviewed
Feb 15, 2019
| @@ -37,6 +37,7 @@ namespace app { | |||
| bool listSlices; | |||
| bool ignoreEmpty; | |||
| bool trim; | |||
| bool trimByGrid; | |||
There was a problem hiding this comment.
About this field you have two options:
- Remove it from this PR (because it's not used)
- Or complete this PR with the trim-by-grid support for
--save-as
…rim-by-grid-CLI # Conflicts: # src/app/cli/cli_processor.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aseprite --trim-by-grid --sheet
(#1926 )