Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app menu may become disabled on macOS #2037

Merged
merged 2 commits into from Mar 23, 2019

Conversation

Projects
None yet
2 participants
@kawa-yoiko
Copy link
Contributor

commented Mar 21, 2019

Hi! I think here is a valid fix for #1974. Please refer to aseprite/laf#7 — both changes need to be applied for the fix.

The reason for the changes in this repo is that according to the automatic validation policy, modal dialogs somehow disable these menu items, and they need to be re-enabled with a validate routine. (Btw, I'd love to hear if there is a better approach ^ ^)

Thanks for the effort and time!

@dacap

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Hi @kawa-yoiko! thanks for your patches, I'll take a look to your contribution soon, in the meanwhile, could you please check the CLA signing process?

@kawa-yoiko

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

I made a little tweak so that the behaviour is consistent with both native and LAF dialogs.

@dacap dacap merged commit 223002c into aseprite:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.