Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/save-as: update to handle format elements #2510

Closed
wants to merge 1 commit into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Sep 10, 2020

Closes #2442

Manually tested with:
a)

aseprite -b $PATH/Sprite-0001.ase --save-as '{title}.png'

Output: Sprite-0001.png

b)

aseprite -b $PATH/Sprite-0001.ase --save-as 'a-{title}-b.png'

Output: a-Sprite-0001-b.png

@anGie44 anGie44 requested a review from dacap as a code owner September 10, 2020 22:20
@dacap
Copy link
Member

dacap commented Sep 15, 2020

Hi @anGie44 thanks for this patch, could you please check the CLA signing process?

@anGie44
Copy link
Contributor Author

anGie44 commented Sep 23, 2020

all set @dacap 👍

@dacap
Copy link
Member

dacap commented Jan 4, 2021

I've tested this patch with a sprite with several frames doing

aseprite -b animation.aseprite -save-as "{title}.png"

and all frames are saved in the same file animation.png. Anyway in previous versions the saved file are {title}1.png, {title}2.png, etc. while the best output would be animation1.png, animation2.png, etc.

I have to oreview this patch and probably merge it with other fixes to avoid breaking some other cases.

@dacap dacap closed this Jul 16, 2021
@dacap dacap deleted the branch aseprite:master July 16, 2021 16:02
@dacap dacap mentioned this pull request Dec 23, 2022
12 tasks
@dacap
Copy link
Member

dacap commented Dec 23, 2022

Thanks a lot @anGie44, I've just merged this PR (it was automatically closed in the past when we deleted the master branch, now we use the main branch).

I've added to support saving multiple files with one -save-as too, as requested in #2442

@dacap dacap added this to the v1.3.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{title} and {name} not working properly
2 participants