Skip to content

Add missing strings in language file (fix #2809) #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

iamOgunyinka
Copy link
Contributor

During a language change, all user-friendly strings should reflect the new change. This PR adds more strings that allows this change to happen.

@iamOgunyinka iamOgunyinka requested a review from dacap as a code owner January 3, 2022 11:39
@dacap
Copy link
Member

dacap commented Jan 3, 2022

Thanks @iamOgunyinka, I'll see if I'm able to merge this in the following days. Actually #2809 was planned for v1.2.31 so the PR should be for main branch. I'll see if I can apply each commit into main first and then merge main into beta.

@dacap
Copy link
Member

dacap commented Oct 7, 2022

I'll merge this/cherry-pick commits after #3548 is done.

@dacap dacap self-assigned this Oct 7, 2022
@dacap dacap added the wip label Oct 11, 2022
@dacap
Copy link
Member

dacap commented Oct 12, 2022

Finally merged 160a3f9 (some commits were modified a little)

Thanks @iamOgunyinka for your help with the project.

@dacap dacap closed this Oct 12, 2022
@dacap dacap removed the wip label Oct 12, 2022
@dacap dacap added the i18n label Oct 12, 2022
@iamOgunyinka
Copy link
Contributor Author

No worries, @dacap. It was a privilege working with you on Aseprite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants