Skip to content

Fix frametags 1514 - #3271

Closed
natebot13 wants to merge 2 commits into
aseprite:mainfrom
natebot13:fix-frametags-1514
Closed

natebot13 wants to merge 2 commits into
aseprite:mainfrom
natebot13:fix-frametags-1514

Conversation

@natebot13

@natebot13 natebot13 commented Apr 29, 2022 •

Copy link
Copy Markdown
Contributor

Fixes issue #1514
Utilizes a subset of the string formatting capabilities to format tag names when exporting to json

I agree that my contributions are licensed under the Individual Contributor License Agreement V3.0 ("CLA") as stated in https://github.com/aseprite/sourcecode/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/aseprite/sourcecode/blob/main/sign-cla.md#sign-the-cla

@natebot13
natebot13 requested a review from dacap as a code owner April 29, 2022 13:32
@natebot13

Copy link
Copy Markdown
Contributor Author

would love to get this reviewed and merged if possible

@dacap dacap self-assigned this Dec 23, 2022
@dacap

dacap commented Dec 23, 2022

Copy link
Copy Markdown
Member

Hi @natebot13, I'll take a look right now.

@dacap

dacap commented Dec 23, 2022

Copy link
Copy Markdown
Member

Thanks for this @natebot13, it's looks great, I've just merged it 👍 I've fixed some conflict (as we moved ExportSpriteSheetParams to cmd_export_sprite_sheet.h), made some adjustments in the UI (+restoring saved tagname format from previous sessions), e.g.

Before
Screenshot from 2022-12-23 09-30-02
after
Screenshot from 2022-12-23 09-45-09

And added a new test. I'll add a new #tagname-format section to the CLI docs right now too.

Thanks again 🙏

@dacap dacap closed this Dec 23, 2022
@dacap dacap added this to the v1.3.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants