New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small UI button set painting fixes #3519
Conversation
This is not as simple as it seems. This fix fixes the Dynamics popup dialog, but changes other buttons. I think there is something deeper to fix (like the general text/icon alignment of a generic button widget). I'll do some more research tomorrow. |
The last row of items are a bit taller to make room for the button border, so this compensates that.
Finally, I think this solution is fine. The text/icon alignment in the last row is consistent with the remaining buttons that are not in the last row. |
src/app/ui/button_set.cpp
Outdated
if (isLastRow && info.row > 0) { | ||
iconRc.y -= 2*guiscale(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor modification: omit the {
}
in the if
… with more than one row (fix #2676)
236f607
to
01de115
Compare
Although some other buttons have changed, I think the new look for the Dynamics is better than before, so I'll merge this as it is. I might add some new properties in the theme to adjust the height of the buttons after main and beta are merged 👍 |
This PR contains 2 fixes to the way ButtonSet items are painted.
One fixes the vertical position of the text, and the other fixes the vertical position of the icon (#2676).