Skip to content

Replace ColorEntry with ExprEntry in Color Sliders #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Akylzhan
Copy link
Contributor

Adds #3900

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

@Akylzhan Akylzhan requested a review from dacap as a code owner June 21, 2023 23:44
@dacap dacap self-assigned this Jun 22, 2023
Copy link
Member

@dacap dacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akylzhan, thanks for your PR. Probably we require a different approach for this. Probably just changing:

class ColorEntry : public ExprEntry

@Akylzhan
Copy link
Contributor Author

@dacap Yes, you are right. Did not think about that. Changed ColorEntry's base to ExprEntry

@dacap
Copy link
Member

dacap commented Jun 23, 2023

Thanks @Akylzhan, I've just merged this change in 3e171d0 with a missing setText("0") so the entry fields start with 0 in the Edit > Adjustments > Hue/Saturation dialog.

@dacap dacap closed this Jun 23, 2023
@Akylzhan Akylzhan deleted the color-sliders-expr-entry branch June 24, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants