Skip to content

Respect slice keys frame number on ase file format (fix #4062) #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

npinochet
Copy link
Contributor

When saving slices on the ASE file format, the starting frame of the slice was not respected and always try to save the slice on frame 0 (fromFrame). Now it takes the fromFrame from the slice if the keys are not empty.
Fixes #4062.

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

@npinochet npinochet requested a review from dacap as a code owner September 23, 2023 02:19
@npinochet npinochet force-pushed the fix-4062 branch 3 times, most recently from c9f3d82 to 86e6cc6 Compare September 24, 2023 00:05
@dacap dacap self-assigned this Sep 25, 2023
@dacap
Copy link
Member

dacap commented Sep 25, 2023

Hi @npinochet, thanks for this PR, remember to sign the CLA document you've received via email from signNow as a last step.

@npinochet
Copy link
Contributor Author

Hi @npinochet, thanks for this PR, remember to sign the CLA document you've received via email from signNow as a last step.

Oh I totally missed that email, now it's signed. Thanks!

@dacap
Copy link
Member

dacap commented Oct 11, 2023

@npinochet sorry, I was going to review this PR but saw that the CLA was signed with a different email address that the one used in this commit (or the email wasn't included in the list of emails)

@dacap dacap added the needs cla The full CLA signing process wasn't completed. label Oct 11, 2023
@npinochet
Copy link
Contributor Author

@npinochet sorry, I was going to review this PR but saw that the CLA was signed with a different email address that the one used in this commit (or the email wasn't included in the list of emails)

Oh I'm sorry, I haven't updated my email on git for a long time, now the emails should match

@dacap dacap removed the needs cla The full CLA signing process wasn't completed. label Oct 11, 2023
@dacap
Copy link
Member

dacap commented Oct 11, 2023

Thanks for the fix @npinochet, it works great 👍

I'm going to merge this as it is, but there are some extreme cases that might be broken, e.g. using the CLI with --frame-range. But I'll add some unit tests to check and fix this with following commits.

@dacap dacap merged commit 4fc36aa into aseprite:main Oct 11, 2023
@npinochet npinochet deleted the fix-4062 branch June 17, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First Slice resets to first frame everytime aseprite is open
2 participants