Skip to content

fixed tag time duration not including ending frame (fix #3668) #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

RowanFuture
Copy link
Contributor

@RowanFuture RowanFuture commented Oct 5, 2023

Fixes #3668

the tag duration counting function was excluding the ending frame of the tag.

I agree that my contributions are licensed under the Individual Contributor License Agreement V4.0 ("CLA") as stated in https://github.com/igarastudio/cla/blob/main/cla.md

I have signed the CLA following the steps given in https://github.com/igarastudio/cla#signing

@RowanFuture RowanFuture requested a review from dacap as a code owner October 5, 2023 13:23
@RowanFuture RowanFuture changed the title Closes aseprite/aseprite#3668 Closes #3668 Oct 5, 2023
@RowanFuture RowanFuture changed the title Closes #3668 fixed tag time duration not including ending frame (Fix #3668) Oct 5, 2023
@RowanFuture RowanFuture changed the title fixed tag time duration not including ending frame (Fix #3668) fixed tag time duration not including ending frame (fix #3668) Oct 5, 2023
@dacap
Copy link
Member

dacap commented Oct 5, 2023

Hi @RowanFuture, thanks for your PR, it looks like we didn't receive the signed CLA. Could you please follow the steps in the Signing section: https://github.com/igarastudio/cla#signing

@RowanFuture
Copy link
Contributor Author

Hi @RowanFuture, thanks for your PR, it looks like we didn't receive the signed CLA. Could you please follow the steps in the Signing section: https://github.com/igarastudio/cla#signing

Signed! :)

@dacap dacap self-assigned this Oct 5, 2023
@dacap
Copy link
Member

dacap commented Oct 5, 2023

Thanks for the fix @RowanFuture! Just merged 👍

@dacap dacap merged commit 27ec013 into aseprite:main Oct 5, 2023
@RowanFuture RowanFuture deleted the patch-1 branch October 5, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent cell speed on animation tooltip.
2 participants