(fix #4721) Implement Editor Toggle to hide or show the preview Brush in the preview Window#4752
(fix #4721) Implement Editor Toggle to hide or show the preview Brush in the preview Window#4752S4HRKBOY wants to merge 1 commit intoaseprite:mainfrom
Conversation
|
Hi there! One or more of the commit messages in this PR do not match our code submission policy, please check the |
S4HRKBOY
force-pushed
the
Disable_Cursor_PreviewWindow
branch
from
daff335 to
d822c1c
Compare
S4HRKBOY
changed the title
aseprite-bot
left a comment
aseprite-bot
left a comment
There was a problem hiding this comment.
clang-tidy made some suggestions
| protected: | ||
| bool onChecked(Context* ctx) override | ||
| { | ||
| DocumentPreferences& docPref = Preferences::instance().document(ctx->activeDocument()); |
There was a problem hiding this comment.
warning: variable 'docPref' of type 'DocumentPreferences &' (aka 'int &') can be declared 'const' [misc-const-correctness]
| DocumentPreferences& docPref = Preferences::instance().document(ctx->activeDocument()); | |
| DocumentPreferences const& docPref = Preferences::instance().document(ctx->activeDocument()); |
| } | ||
| void onExecute(Context* ctx) override | ||
| { | ||
| DocumentPreferences& docPref = Preferences::instance().document(ctx->activeDocument()); |
There was a problem hiding this comment.
warning: variable 'docPref' of type 'DocumentPreferences &' (aka 'int &') can be declared 'const' [misc-const-correctness]
| DocumentPreferences& docPref = Preferences::instance().document(ctx->activeDocument()); | |
| DocumentPreferences const& docPref = Preferences::instance().document(ctx->activeDocument()); |
|
Thanks @S4HRKBOY, I'll test this and probably modify the patch a little for the final merge/cherry-pick. |
|
I've cherry-picked ( cd5bf49 ) this with a few changes (removing unnecessary |
3 participants
This PR is for the issue #4721
In this PR i implemented a simple function to toggle the preview brush inside the preview window with a new Menu-Item and the corrisponding Command. A preview can be seen in a little video in this PR Message (Only the first 30s are relevant - rest of the video is freezing :X).
Aseprite-test.webm