Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FreeBSD get_app_path #893

Merged
merged 1 commit into from Dec 9, 2015
Merged

Conversation

@tony
Copy link
Contributor

tony commented Dec 8, 2015

Fixes #889

Add support with and without procfs.

See also: https://www.libsdl.org/tmp/SDL/src/filesystem/unix/SDL_sysfilesystem.c

@dacap
dacap reviewed Dec 8, 2015
View changes
src/base/fs_unix.h Outdated
#else

if (!path[0] && (access("/proc", F_OK) == 0)) {
#if defined(__FREEBSD__)

This comment has been minimized.

Copy link
@dacap

dacap Dec 8, 2015

Member

Why __FREEBSD__ instead of __FreeBSD__? Is it __FreeBSD__ or __FREEBSD__?

@dacap
dacap reviewed Dec 8, 2015
View changes
src/base/fs_unix.h Outdated

#else

if (!path[0] && (access("/proc", F_OK) == 0)) {

This comment has been minimized.

Copy link
@dacap

dacap Dec 8, 2015

Member

Is this required in OS X? why isn't this inside __FreeBSD__? Also this line needs a correct indentation.

Fixes #889

Add support with and without procfs.

See also: https://www.libsdl.org/tmp/SDL/src/filesystem/unix/SDL_sysfilesystem.c
@tony tony force-pushed the tony:freebsd-app_path branch to 382881a Dec 9, 2015
@tony
Copy link
Contributor Author

tony commented Dec 9, 2015

@dacap better now

@dacap
Copy link
Member

dacap commented Dec 9, 2015

Yeah, now it looks better 😄 Thanks for the patch!

dacap added a commit that referenced this pull request Dec 9, 2015
Support for FreeBSD get_app_path
@dacap dacap merged commit f1c1c58 into aseprite:master Dec 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony tony deleted the tony:freebsd-app_path branch Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.