Support for FreeBSD get_app_path #893

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
2 participants
@tony
Contributor

tony commented Dec 8, 2015

Fixes #889

Add support with and without procfs.

See also: https://www.libsdl.org/tmp/SDL/src/filesystem/unix/SDL_sysfilesystem.c

src/base/fs_unix.h
-#else
-
+if (!path[0] && (access("/proc", F_OK) == 0)) {
+#if defined(__FREEBSD__)

This comment has been minimized.

@dacap

dacap Dec 8, 2015

Member

Why __FREEBSD__ instead of __FreeBSD__? Is it __FreeBSD__ or __FREEBSD__?

@dacap

dacap Dec 8, 2015

Member

Why __FREEBSD__ instead of __FreeBSD__? Is it __FreeBSD__ or __FREEBSD__?

src/base/fs_unix.h
-#else
-
+if (!path[0] && (access("/proc", F_OK) == 0)) {

This comment has been minimized.

@dacap

dacap Dec 8, 2015

Member

Is this required in OS X? why isn't this inside __FreeBSD__? Also this line needs a correct indentation.

@dacap

dacap Dec 8, 2015

Member

Is this required in OS X? why isn't this inside __FreeBSD__? Also this line needs a correct indentation.

@tony

This comment has been minimized.

Show comment
Hide comment
@tony

tony Dec 9, 2015

Contributor

@dacap better now

Contributor

tony commented Dec 9, 2015

@dacap better now

@dacap

This comment has been minimized.

Show comment
Hide comment
@dacap

dacap Dec 9, 2015

Member

Yeah, now it looks better 😄 Thanks for the patch!

Member

dacap commented Dec 9, 2015

Yeah, now it looks better 😄 Thanks for the patch!

dacap added a commit that referenced this pull request Dec 9, 2015

Merge pull request #893 from tony/freebsd-app_path
Support for FreeBSD get_app_path

@dacap dacap merged commit f1c1c58 into aseprite:master Dec 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tony tony deleted the tony:freebsd-app_path branch Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment