Skip to content

Comments

Suggest git submodule init / update in README#125

Closed
martinemde wants to merge 1 commit intoaseprite:mainfrom
martinemde:martinemde/suggest-submodule-init
Closed

Suggest git submodule init / update in README#125
martinemde wants to merge 1 commit intoaseprite:mainfrom
martinemde:martinemde/suggest-submodule-init

Conversation

@martinemde
Copy link

@martinemde martinemde commented Jan 4, 2025

When I went to build this (after building skia) I had these errors that blocked the build:

CMake Error at CMakeLists.txt:62 (add_subdirectory):
  The source directory

   path/to/laf/clip

  does not contain a CMakeLists.txt file.


CMake Error at third_party/CMakeLists.txt:10 (add_subdirectory):
  The source directory

   path/to/laf/third_party/googletest

  does not contain a CMakeLists.txt file.

The solution is to init and update submodules after cloning.

git submodule update --init

This will fetch the correct files and allow you to build.

It would be nice to make sure others know to init and update submodules when they fetch the code. I rarely work in projects that have submodules so I didn't immediately realize this was simple to solve.

I agree that my contributions are licensed under the MIT License.
You can find a copy of this license at https://opensource.org/licenses/MIT

@dacap dacap self-assigned this Jan 6, 2025
@dacap dacap closed this in 97ac7e4 Apr 16, 2025
@dacap
Copy link
Member

dacap commented Apr 16, 2025

Thanks for this @martinemde, I've updated the instructions to use git clone --recursive which is the preferred method to initialize the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants