diff --git a/.changeset/lazy-forks-sneeze.md b/.changeset/lazy-forks-sneeze.md new file mode 100644 index 00000000..3435aeab --- /dev/null +++ b/.changeset/lazy-forks-sneeze.md @@ -0,0 +1,6 @@ +--- +'@asgardeo/react': patch +'@asgardeo/javascript': patch +--- + +Fix `SignInButton` issue with `AsgardeoV2` diff --git a/README.md b/README.md index 786905b7..f12ee557 100644 --- a/README.md +++ b/README.md @@ -48,6 +48,14 @@ Follow these simple steps to get started with Asgardeo: Please read [Contributing Guide](CONTRIBUTING.md) for details on how to contribute to Asgardeo JavaScript SDKs. Refer to [General Contribution Guidelines](http://wso2.github.io/) for details on our code of conduct, and the process for submitting pull requests to us. +### Contributors ❤️ + +Hats off to all the people who have contributed to this project, including those who created issues and participated in discussions. 🙌 + + + + + ### Reporting issues We encourage you to report issues, improvements, and feature requests creating [Github Issues](https://github.com/asgardeo/javascript/issues). diff --git a/packages/javascript/src/models/embedded-flow.ts b/packages/javascript/src/models/embedded-flow.ts index 5fd7c125..a0d55ea1 100644 --- a/packages/javascript/src/models/embedded-flow.ts +++ b/packages/javascript/src/models/embedded-flow.ts @@ -16,8 +16,6 @@ * under the License. */ -import {Platform} from './platforms'; - export enum EmbeddedFlowType { Authentication = 'AUTHENTICATION', Registration = 'REGISTRATION', diff --git a/packages/react/src/AsgardeoReactClient.ts b/packages/react/src/AsgardeoReactClient.ts index db773b65..6f39bc00 100644 --- a/packages/react/src/AsgardeoReactClient.ts +++ b/packages/react/src/AsgardeoReactClient.ts @@ -48,6 +48,7 @@ import { Config, TokenExchangeRequestConfig, Platform, + isEmpty, } from '@asgardeo/browser'; import AuthAPI from './__temp__/api'; import getMeOrganizations from './api/getMeOrganizations'; @@ -334,7 +335,7 @@ class AsgardeoReactClient e const config: AsgardeoReactConfig = (await this.asgardeo.getConfigData()) as AsgardeoReactConfig; - if (config.platform === Platform.AsgardeoV2) { + if (config.platform === Platform.AsgardeoV2 && typeof arg1 === 'object' && !isEmpty(arg1)) { const sessionDataKey: string = new URL(window.location.href).searchParams.get('sessionDataKey'); return executeEmbeddedSignInFlowV2({ diff --git a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx index ded01e55..190acf59 100644 --- a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx +++ b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx @@ -346,7 +346,7 @@ const AsgardeoProvider: FC> = ({ useEffect(() => { // TEMPORARY: Asgardeo V2 platform does not support branding preference yet. // Tracker: https://github.com/asgardeo/javascript/issues/212 - if (config.platform !== Platform.AsgardeoV2) { + if (config.platform === Platform.AsgardeoV2) { return; }