Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ash-window: Upgrade to raw-window-handle 0.5.0 #645

Merged
merged 7 commits into from
Sep 23, 2022
Merged

ash-window: Upgrade to raw-window-handle 0.5.0 #645

merged 7 commits into from
Sep 23, 2022

Conversation

MarijnS95
Copy link
Collaborator

ash-window/src/lib.rs Outdated Show resolved Hide resolved
@MarijnS95
Copy link
Collaborator Author

We'll have to wait some for rust-windowing/winit#2400 to back out of the 1.60 MSRV change.

ash-window/src/lib.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 force-pushed the rwh-0.5 branch 2 times, most recently from fc1aabf to a484fbd Compare July 29, 2022 20:33
jo12bar added a commit to jo12bar/vulkan-tutorial-rs that referenced this pull request Aug 15, 2022
Also downgrade winit to fix version compatibility of raw-window-handle
with ash-window. This can be undone once
ash-rs/ash#645 is merged.
@MarijnS95 MarijnS95 requested review from msiglreith, kchibisov and Ralith and removed request for msiglreith and kchibisov September 19, 2022 09:58
While the examples technically aren't part of our MSRV requirement (it's
nice, but core crate compatibility is much more important), it's
annoying to exempt these especially now that `winit` removed some
unneeded MSRV 1.60/1.61 requirements.
@MarijnS95 MarijnS95 merged commit b4fc334 into master Sep 23, 2022
@MarijnS95 MarijnS95 deleted the rwh-0.5 branch September 23, 2022 10:40
MarijnS95 added a commit that referenced this pull request Sep 23, 2022
* ash-window: Upgrade to raw-window-handle 0.5.0

* Bump `raw-window-metal` to recently-released `0.3`

norse-rs/raw-window-metal#5

* examples: Bump `winit` to `0.27.1` to resolve our MSRV tests

While the examples technically aren't part of our MSRV requirement (it's
nice, but core crate compatibility is much more important), it's
annoying to exempt these especially now that `winit` removed some
unneeded MSRV 1.60/1.61 requirements.

* Take `Raw{Display,Window}Handle` directly instead of through trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants