Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/ext: Add VK_EXT_extended_dynamic_state3 #671

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

MarijnS95
Copy link
Collaborator

Depends on #667, cc @wrightwriter

@coffeenotfound
Copy link

When is this going to be merged? I would really need ext_dynamic_state3

@MarijnS95 MarijnS95 force-pushed the ext-extended-dynamic-state branch 3 times, most recently from 2021ae1 to 7e88f8b Compare November 18, 2022 19:12
@MarijnS95
Copy link
Collaborator Author

@coffeenotfound Whenever it receives review.

@MarijnS95 MarijnS95 merged commit 8756155 into master Nov 22, 2022
@MarijnS95 MarijnS95 deleted the ext-extended-dynamic-state branch November 22, 2022 22:28
@wrightwriter
Copy link

i'm wondering if it makes sense to have the dynamic state extensions as a traits on device.

@MarijnS95
Copy link
Collaborator Author

MarijnS95 commented Dec 2, 2022

Hardly any of the functions take a VkDevice, I think you're more so intending this to be on VkCommandBuffer.

Unless you're intending for a model where ash::Device loads and stores all device functions, including all extensions, I think Erupt does something like that.

@wrightwriter
Copy link

Ok, my logic was that core vkCmd are on the device. But what you are saying makes sense.

@MarijnS95
Copy link
Collaborator Author

Most of these functions are loaded for a device (and vk::CommandBuffer is a special child specific to a single vk::Device), and all the standardized .cmd_ function are hence loaded for and available on a device.

The main point is that we didn't force this for extensions, so that the ash::Device object doesn't get too bloated with all extensions and their optionally-loaded/available functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants