Add support for Carthage #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
# Conflicts: # .gitignore # .gitmodules
|
Why the close? Was going to merge this. |
|
Hey @ashfurrow, sorry, I want to make sure everything is in place, the Travis CI passes, and I add the Carthage step on the CHANGELOG. I closed it so you didn't lose the time before I get that done, sorry about the confusion. |
|
Cool cool, just re-open when you're ready 馃憤 |
|
I think now it's ready 馃槂 Ok so, I couldn't think of a way of having both Swift versions (2.3 and 3.0) working with Carthage (because of the dependencies), so I had to release 2 versions to make clear which one supports which version:
|
|
Super-awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃槉
First, thank you for your continuos support and work on the OSS community 馃嵒
So, just if you're interested in adding support for Carthage, this PR adds it.
I know that accepting this, it might add to this project the need to keep the support for that dependency manager in the future, so up to you 馃槂
On other news, this goes with the
Quick v0.9.3andNimble v4.1.xversions that support Swift 2.3. To support Swift 3, as you may know, we should change the versions to useQuick v1.xandNimble v5.x.隆Ya tu sabes! 馃嵎
cc @juolgon