Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 More Years of Software Development #396

Merged
merged 28 commits into from Dec 17, 2019
Merged

5 More Years of Software Development #396

merged 28 commits into from Dec 17, 2019

Conversation

@ashfurrow
Copy link
Owner

ashfurrow commented Jul 27, 2019

Starting this one early.

@netlify

This comment has been minimized.

Copy link

netlify bot commented Jul 27, 2019

Deploy preview for ashfurrow-blog ready!

Built with commit 832fdd3

https://deploy-preview-396--ashfurrow-blog.netlify.com

ashfurrow added 25 commits Aug 3, 2019
@orta

This comment has been minimized.

Copy link
Contributor

orta commented Dec 16, 2019

Hah - this is like impossible to find things for review in the changed files

Design opinons, no need to take it

Grey boxes

The boxes with a shadow is a bit fuzzy and feels like accidental design (the gradient from the shadow merges from the bg and it doesn't quite 'contain' the content in terms of whitespace/layout (IMO)

I tried tweaking it a bit with:

.thingy {
border: 1px solid darkgrey;
box-shadow: rgba(0, 0, 0, 0.2) 0px 1px 2px 0px;
background-color: rgb(248, 248, 248);
}

Screen Shot 2019-12-16 at 9 39 27 AM

Timing

I lose track of the time period really quickly. Could the year scroll down through the center? (its only 4 chars so you probably don't need to change layout) - look at position: sticky in CSS, probably a 2-3 liner.

Also, might not be important.

Maybe even shows the progress of the year?

Screen Shot 2019-12-16 at 10 00 26 AM

A third rail

There are occasionally much longer, more thought out and deeper sections which tend tp be a bit like life junction points, like "A Broadening Technical Perspective" and "Stepping up." These feel like they could pop out across both columns e.g.

Screen Shot 2019-12-16 at 10 12 12 AM

This gives you the ability to re-consider if there are places you want to dive back in for a deeper run

Text

But at the time, this was as far as I had pushed into it.

Feels weak as a sentence. This is your first time pushing and focusing on this idea publicly which started to become a core thing you talk about for half a decade - I'd hammer that point. Also, no link?

“I watched your talk. Let’s do it.”

TIL'd (or maybe I forgot and re-learned)

and I was hungry for more.

Live Auctions Integration#

Could maybe include some links to some of the blog posts on building LAI?

Or links to pics of the kiosks IRL to give context

the NAFTA visa

Link, that's interesting if you don't know what it is

It had some restrictions that we were initially okay with, but grew tired of as we continued living in the states

Center feels a bit clumsy, and maybe 'It' -> 'This VISA'

I found this work really fulfilling. Something about making my colleague’s jobs easier just felt satisfying in a new, fresh way to me.

Glad you mention this - I agree, this supporting something grow stuff was fun and some different and interesting problems

I hesitated: “I’m just an iOS developer.” “Whatever, you know code.” And I was like “huh, yeah.” And we figured out the problem together.

I lol'd

I’ve spent nearly six years at Artsy, and that has taught me that change is constant...

I like this paragraph, but I can't quite put my finger on why it's not quite got the impact I'd like it to have, maybe the rhythm?

@ashfurrow

This comment has been minimized.

Copy link
Owner Author

ashfurrow commented Dec 16, 2019

@orta that's all awesome feedback, thank you 🙏 I like the visual design suggestions you've made, but I've left this post quite late and find myself feeling slightly constrained by the library I'm using (though their styling extension mechanism are very robust). I'm going to use the time I have to improve the prominence of years, to help orient the reader, and the flow of large text blocks.

Your feedback on the prose is also very helpful, thank you.

ashfurrow added a commit that referenced this pull request Dec 17, 2019
@ashfurrow

This comment has been minimized.

Copy link
Owner Author

ashfurrow commented Dec 17, 2019

Opened #409 to revisit the designs with my own timeline implementation.

@ashfurrow ashfurrow changed the title [WIP] 5 More Years of Software Development 5 More Years of Software Development Dec 17, 2019
@ashfurrow ashfurrow merged commit 6c526af into master Dec 17, 2019
@ashfurrow ashfurrow deleted the 5-more-years branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.