Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Gatsby Migration #402
Left to do:
This is a "Flash Of Unstyled Content" bug that happens with FontAwesome's icons. While the initial JS is loading, the icons are rendered at their inherent size (the SVG's are based on a 512px grid, so it uses that). This commit adds styling to the component in a way that bypasses the React component lifecycle, so it doesn't require JS to be loaded and will instead be included with the initial page payload. Yay!
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.