-
Notifications
You must be signed in to change notification settings - Fork 16
Inline mode #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline mode #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, nice approach with DI on those functions 👍
Update: So the Danger JS and Danger Swift inline mode was merged! Danger JS is already released and @orta is playing with Danger Swift to get all the things working for the release as well. Once Danger Swift is released, I'm gonna add documentation and we could use a final review for this one! Update2: IT'S GREEN EVERYBODY. Writing docs as we speak. |
@ashfurrow okay, Danger Swift is released, I've added Edit: or wait, seems like there is one tiny bug to fix 😄 Edit2: OMG, it's working. See Harvey#17. Basically SwiftLint always returned absolute path and because we had relative ones, we could swap it after generating Violations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small note, not a blocker. Merge when you're ready 👍
@@ -31,6 +31,14 @@ SwiftLint.lint() | |||
|
|||
That will lint the created and modified files | |||
|
|||
#### Inline mode | |||
|
|||
If you want the lint result shows in diff instead of comment, you can use inline_mode option. Violations that out of the diff will show in danger's fail or warn section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any Danger docs or code we could link to from here, to give more context about what inline mode is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good idea. I will add a link to the release notes of Danger JS, it's really well written 👍
(This needs to wait before danger-swift#56 is merged, though)merged now 😉Todo: