New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline mode #9

Merged
merged 6 commits into from Apr 2, 2018

Conversation

2 participants
@sunshinejr
Collaborator

sunshinejr commented Mar 4, 2018

(This needs to wait before danger-swift#56 is merged, though) merged now 馃槈

Todo:

  • Add documentation
  • Add Changelog entry

@sunshinejr sunshinejr referenced this pull request Mar 5, 2018

Closed

[DON'T MERGE] Danger test. #17

3 of 3 tasks complete
@ashfurrow

Cool, nice approach with DI on those functions 馃憤

@sunshinejr sunshinejr changed the title from [WIP] Inline mode to Inline mode Mar 24, 2018

@sunshinejr

This comment has been minimized.

Collaborator

sunshinejr commented Mar 31, 2018

Update: So the Danger JS and Danger Swift inline mode was merged! Danger JS is already released and @orta is playing with Danger Swift to get all the things working for the release as well. Once Danger Swift is released, I'm gonna add documentation and we could use a final review for this one!

Update2: IT'S GREEN EVERYBODY. Writing docs as we speak.

@sunshinejr sunshinejr force-pushed the sunshinejr:inline branch from 58d01e5 to 957f7c8 Mar 31, 2018

@sunshinejr sunshinejr force-pushed the sunshinejr:inline branch from 957f7c8 to 885fef0 Mar 31, 2018

@sunshinejr

This comment has been minimized.

Collaborator

sunshinejr commented Mar 31, 2018

@ashfurrow okay, Danger Swift is released, I've added Changelog entry & documentation. Should be ready for the final review 馃槈

Edit: or wait, seems like there is one tiny bug to fix 馃槃
zrzut ekranu 2018-04-01 o 01 08 48

Edit2: OMG, it's working. See Harvey#17. Basically SwiftLint always returned absolute path and because we had relative ones, we could swap it after generating Violations.

@ashfurrow

Looks great! Just one small note, not a blocker. Merge when you're ready 馃憤

@@ -31,6 +31,14 @@ SwiftLint.lint()
That will lint the created and modified files
#### Inline mode
If you want the lint result shows in diff instead of comment, you can use inline_mode option. Violations that out of the diff will show in danger's fail or warn section.

This comment has been minimized.

@ashfurrow

ashfurrow Apr 2, 2018

Owner

Is there any Danger docs or code we could link to from here, to give more context about what inline mode is?

This comment has been minimized.

@sunshinejr

sunshinejr Apr 2, 2018

Collaborator

Yeah, good idea. I will add a link to the release notes of Danger JS, it's really well written 馃憤

@sunshinejr sunshinejr merged commit 590a160 into ashfurrow:master Apr 2, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the sunshinejr:inline branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment