Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for \u sequences in JSON #643

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

ekaitz-zarraga
Copy link
Contributor

@ekaitz-zarraga ekaitz-zarraga commented May 18, 2020

I'm not sure if this is the best way to do it but it works for simple \u sequences of UTF8 characters.

I'm not sure how should I make it compatible with compilation with SEXP_USE_UTF8_STRINGS set to false.

Ideas on that?

@ashinn ashinn merged commit 8df9f7c into ashinn:master May 19, 2020
1 check passed
@ashinn
Copy link
Owner

ashinn commented May 19, 2020

This looks fine.

Setting SEXP_USE_UTF8_STRINGS to false doesn't prevent encoding utf8 in strings, it just means basic string operations (string-ref, string-length, etc.) will work at the 8-bit byte level. So the JSON will be read correctly (and written correctly), but possibly not processed correctly depending on what you do with it in Scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants