Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite implementation of FairTensor using AxisArrays? #36

Open
jiahao opened this issue Aug 1, 2020 · 1 comment
Open

Rewrite implementation of FairTensor using AxisArrays? #36

jiahao opened this issue Aug 1, 2020 · 1 comment

Comments

@jiahao
Copy link

jiahao commented Aug 1, 2020

The functionality for FairTensor seems to be primarily to store labels together with the fairness-confusion tensor. This functionality already exists in https://github.com/JuliaArrays/AxisArrays.jl and I think it would make sense to define FairTensor as an AxisArray.

Also, let's discuss why FairTensor needs to be mutable - there are potential performance penalty issues with the current design.

@ashryaagr
Copy link
Owner

The LinProgWrapper required the FairTensor to be mutable. But in the commit 62de9fd , I have fixed this requirement and FairTensor (and all wrappers) are now immutable. Thanks for pointing out!

The Pull Request #37 replaces FairTensor with AxisArray. But I think it is better to stick to the struct FairTensor instead of replacing it with AxisArray. The use of FairTensor struct clearly demonstrates a separate entity: FairTensor. I feel that things might get confusing for contributors if we use AxisArray as replacement of FairTensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants