Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fade in-out effects to the playback #124

Merged
merged 5 commits into from Apr 9, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Added fadeIn() and fadeOut() methods to the Playback class
  • Minor changes to PlaybackManager to adapt new changes in Playback

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #124 into master will increase coverage by 0.34%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     77.64%   77.99%   +0.34%     
- Complexity      102      107       +5     
============================================
  Files            11       11              
  Lines           689      709      +20     
  Branches         83       85       +2     
============================================
+ Hits            535      553      +18     
  Misses           88       88              
- Partials         66       68       +2     
Impacted Files Coverage Δ Complexity Δ
...a/com/github/ashutoshgngwr/noice/sound/Playback.kt 78.75% <91.30%> (+3.75%) 23.00 <4.00> (+5.00)
...ithub/ashutoshgngwr/noice/sound/PlaybackManager.kt 75.23% <100.00%> (ø) 26.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f47824...5c28ed3. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit c2506fe into master Apr 9, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/playback-fade-in-out branch April 9, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fade-in and fade-out effects for looping sounds
1 participant