chishop docs say to edit settings.py, but bin/django and bin/django.wsgi use development.py #7

Closed
carljm opened this Issue Dec 10, 2009 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

carljm commented Dec 10, 2009

Took me a bit to figure out why the database settings I changed in chishop/settings.py weren't taking effect. I had to look in bin/django and bin/django.wsgi to notice that they were both using chishop/development.py settings, which overrides the database settings. The docs at least should be fixed to note this.

Owner

ask commented Dec 10, 2009

Yes, I guess settings.py should be renamed to conf/default.py, development.py to settings.py and there should be a settings/production_example.py.

Contributor

carljm commented Dec 13, 2009

Not entirely clear how the bikeshed should be painted here (I don't use buildout), but a possible fix (works for me): http://github.com/carljm/chishop/commit/8b1bb7b106f753c2b28284c4516cc1e9f27c2841

Owner

ask commented Dec 13, 2009

Yeah, me neither. But your patches look good to me, I guess someone will complain if it's not how it's usually done.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment