Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejected trades are now recreated #2721

Closed
wants to merge 1 commit into from

Conversation

@crypto49er
Copy link
Contributor

crypto49er commented Feb 6, 2019

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

When a trade is rejected in Coinbase Pro because the price moved after Gekko sent the trade to the exchange, a new trade isn't recreated (can't retry the trade as the exchanged deleted it). Gekko holds asset that wasn't sold until the user intervenes by manually selling (and restarting Gekko). Rejected buy orders also require user intervention as Gekko thinks it bought the asset and won't respond to a new buy order until a sell order is issued.

  • What is the new behavior (if this is a feature change)?

Gekko will note the error in terminal, recalculate the price based on ticker info, and recreate the trade using new price information.

  • Other information:
crypto49er
@stale

This comment has been minimized.

Copy link

stale bot commented Apr 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

@stale stale bot added the wontfix label Apr 7, 2019
@crypto49er

This comment has been minimized.

Copy link
Contributor Author

crypto49er commented Apr 8, 2019

Keeping this pull request alive. This is a serious issue that has lost money for me and others that use Coinbase Pro.

@stale stale bot removed the wontfix label Apr 8, 2019
@sboydell

This comment has been minimized.

Copy link

sboydell commented Apr 8, 2019

Agree with crypto49er here, this fix is needed for coinbase trades.

@stale

This comment has been minimized.

Copy link

stale bot commented Jun 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

@stale stale bot added the wontfix label Jun 18, 2019
@crypto49er

This comment has been minimized.

Copy link
Contributor Author

crypto49er commented Jun 20, 2019

This issue might have been fixed with this recent commit (a143345), but I want to keep this open until I or some one can confirm by forcing a trade that will be rejected in Coinbase Pro, instructions here: https://forum.gekko.wizb.it/thread-57832.html

@stale stale bot removed the wontfix label Jun 20, 2019
@stale

This comment has been minimized.

Copy link

stale bot commented Aug 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.

@stale stale bot added the wontfix label Aug 19, 2019
@stale stale bot closed this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.