Fix Specs#6
Merged
Merged
Conversation
Contributor
Author
|
This is also a good test to see if #5 is relevant or not. |
Contributor
Author
|
CI passed on this branch, and it looks like master has been failing for a while -- see https://travis-ci.org/askn/faker/builds/430510624 This PR will get master back to green and be compatible with Crystal 0.26.1 |
Owner
|
Thank you @rickychilcott 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I ran the specs on Crystal 0.26.1, I found that many of the specs were broken.
At first, it wouldn't compile, because
parsewas being used, and a location wasn't being provided. I switched to usingparse_localand it built ok. Then I updated all of the spec files to work correctly on my machine. I'm not sure if the seeding works differently across OSs, but I'm on a Mac.Can you review and see if this is helpful?