Fix string tolerance option (#480) #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
micheleriva
reviewed
Oct 11, 2023
H4ad
reviewed
Oct 11, 2023
| @@ -87,7 +87,7 @@ function validateComponents<OramaSchema, TIndex, TDocumentStore, TSorter, TOrama | |||
| } | |||
|
|
|||
| export async function create< | |||
| const OramaSchema, | |||
There was a problem hiding this comment.
@micheleriva This change will break the inference of schemas
There was a problem hiding this comment.
That line was showing a linting error. I don't know why const would be used in a generic type parameter. reverting this change has no effect on fix and will still work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #480
Added a testcase for the (issue #480).
Confirmed bug by testcase fail.
Added Levenshtein distance calculation on radix tree.
distance on tree is only calculated if exact option is not used and tolerance>0. (existing logic is used if tolerance is 0 or exact is true)
Confirmed all testcases(including added testcase of #480) passed.