Commits on Feb 22, 2010
  1. Include missing modules.

    josevalim committed Feb 22, 2010
  2. Adding options to register observers and interceptors through ActionM…

    …ailer::Base.register_observer and ActionMailer::Base.register_interceptor. These hook into Mail.register_interceptor and Mail.register_observer. Also bumped Mail requirement to 2.1.3
    Signed-off-by: José Valim <>
    mikel committed with josevalim Feb 22, 2010
  3. don't set in generated mailer test

    Signed-off-by: Mikel Lindsaar <>
    Signed-off-by: José Valim <>
    dchelimsky committed with josevalim Feb 21, 2010
  4. Fix AMo isolated tests.

    josevalim committed Feb 22, 2010
Commits on Feb 21, 2010
  1. Use ActionDispatch::Routing everywhere

    MSch committed with Yehuda Katz Feb 21, 2010
  2. Typo

    MSch committed with Yehuda Katz Feb 21, 2010
  3. Add a tests which ensures filtered_parameters does not raise an error…

    … for a mixed array [#3928 status:resolved]
    josevalim committed Feb 21, 2010
  4. Add validators reflection so you can do 'Person.validators' and 'Pers…

    Signed-off-by: José Valim <>
    sikachu committed with josevalim Feb 18, 2010
  5. Require persisted? in ActiveModel::Lint and remove new_record? and de…

    …stroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
    josevalim committed Feb 21, 2010
  6. AMo #key is now #to_key and CI is probably happy

    Obviously #key is a too common name to be included
    in the AMo interface, #to_key fits better and also
    relates nicely to #to_param. Thx wycats, koz and
    josevalim for the suggestion.
    AR's #to_key implementation now takes customized
    primary keys into account and there's a testcase
    for that too.
    The #to_param AMo lint makes no assumptions on how
    the method behaves in the presence of composite
    primary keys. It leaves the decision wether to
    provide a default, or to raise and thus signal to
    the user that implementing this method will need
    his special attention, up to the implementers. All
    AMo cares about is that #to_param is implemented
    and returns nil in case of a new_record?.
    The default CompliantObject used in lint_test
    provides a naive default implementation that just
    joins all key attributes with '-'.
    The #to_key default implementation in lint_test's
    CompliantObject now returns [id] instead of [1].
    This was previously causing the (wrong) tests I
    added for AR's #to_key implementation to pass. The
    #to_key tests added with this patch should be
    The CI failure was caused by my lack of knowledge
    about the test:isolated task. The tests for the
    record_identifier code in action_controller are
    using fake non AR models and I forgot to stub the
    #to_key method over there. This issue didn't come
    up when running the test task, only test:isolated
    revealed it. This patch fixes that.
    All tests pass isolated or not, well, apart from
    one previously unpended test in action_controller
    that is unrelated to my patch.
    snusnu committed with Yehuda Katz Feb 21, 2010
Commits on Feb 20, 2010
  1. Adds #key and #to_param to the AMo interface

    This commit introduces two new methods that every
    AMo compliant object must implement. Below are the
    default implementations along with the implied
    interface contract.
      # Returns an Enumerable of all (primary) key
      # attributes or nil if new_record? is true
      def key
        new_record? ? nil : [1]
      # Returns a string representing the object's key
      # suitable for use in URLs, or nil if new_record?
      # is true
      def to_param
        key ? key.first.to_s : nil
    1) The #key method
    Previously rails' record_identifier code, which is
    used in the #dom_id helper, relied on calling #id
    on the record to provide a reasonable DOM id. Now
    with rails3 being all ORM agnostic, it's not safe
    anymore to assume that every record ever will have
    an #id as its primary key attribute.
    Having a #key method available on every AMo object
    means that #dom_id can be implemented using
      record.to_model.key # instead of
    Using this we're able to take composite primary
    keys into account (e.g. available in datamapper)
    by implementing #dom_id using a newly added
    method. The user can overwrite this method to
    provide customized versions of the object's key
    used in #dom_id.
    Also, dealing with more complex keys that can
    contain arbitrary strings, means that we need to
    make sure that we only provide DOM ids that are
    valid according to the spec. For this reason, this
    patch sends the key provided through a newly added
    method, that makes sure we only produce valid HTML
    The reason to not just add #dom_id to the AMo
    interface was that it feels like providing a DOM
    id should not be a model concern. Adding #dom_id
    to the AMo interface would force these concern on
    the model, while it's better left to be implemented
    in a helper.
    Now one could say the same is true for #to_param,
    and actually I think that it doesn't really fit
    into the model either, but it's used in AR and it's
    a main part of integrating into the rails router.
    This is different from #dom_id which is only used
    in view helpers and can be implemented on top of a
    semantically more meaningful method like #key.
    2) The #to_param method
    Since the rails router relies on #to_param to be
    present, AR::Base implements it and returns the
    id by default, allowing the user to overwrite the
    method if desired.
    Now with different ORMs integrating into rails,
    every ORM railtie needs to implement it's own
    #to_param implementation while already providing
    code to be AMo compliant. Since the whole point of
    AMo compliance seems to be to integrate any ORM
    seamlessly into rails, it seems fair that all we
    really need to do as another ORM, is to be AMo
    compliant. By including #to_param into the official
    interface, we can make sure that this code can be
    centralized in the various AMo compliance layers,
    and not be added separately by every ORM railtie.
    3) All specs pass
    snusnu committed with Yehuda Katz Feb 20, 2010
  2. Fix a bunch of pending tests by providing an introspection mode for t…

    …he Response object that does up-front parsing of the headers to populate things like @etag
    Carlhuda committed Feb 20, 2010
Commits on Feb 19, 2010
  1. Revert "i18n translate with arrays issue solved"

    This reverts commit e7055e5.
    Yehuda Katz committed Feb 19, 2010
  2. i18n translate with arrays issue solved

    spastorino committed with Yehuda Katz Feb 19, 2010
  3. require publicize_conversion_method to ensure to_date and to_datetime…

    … became public before redefining them (avoid warnings)
    spastorino committed with Yehuda Katz Feb 19, 2010
  4. Remove empty line and trailing hash, breaks documentation generation

    Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
    dbussink committed with Yehuda Katz Feb 19, 2010
  5. Fix a problem where nil was appearing in the list

    Yehuda Katz committed Feb 19, 2010
  6. Reinstate pending tests that were supposed to be fixed before the

    Shout louder this time so they actually get fixed.
    josh committed Feb 19, 2010
  7. Allow to choose the template path and template name used in implicit …

    …rendering with ActionMailer.
    josevalim committed Feb 19, 2010
  8. Revert behavior from a5684df and ensure after_initializer is executed…

    … after to_prepare callbacks.
    josevalim committed Feb 19, 2010
  9. ruby 1.9 array.to_s returns a string representing an escaped array

    Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
    spastorino committed with Yehuda Katz Feb 19, 2010
  10. Git fail

    Yehuda Katz committed Feb 19, 2010
  11. i18n translate with arrays issue solved

    Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
    spastorino committed with Yehuda Katz Feb 19, 2010
  12. Avoid calling triggering const_missing if const_missing is private wh…

    …en doing constantize
    Carl Lerche committed Feb 19, 2010
Commits on Feb 18, 2010
  1. Don't constantize possible module names when looking for new constant…

    …s unless they exist
    Yehuda Katz committed Feb 18, 2010
  2. Update Renderer

    Yehuda Katz committed Feb 18, 2010