Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with set -e #11

Open
giorgiosironi opened this issue Mar 6, 2017 · 1 comment
Open

Run with set -e #11

giorgiosironi opened this issue Mar 6, 2017 · 1 comment

Comments

@giorgiosironi
Copy link

When I run with the bash -e option (stop at first command with a return code different from 0), the tests terminate at the first check because of this increment:

+ _smoke_success '2xx Response code'
+ REASON='2xx Response code'
+ _smoke_print_success '2xx Response code'
+ TEXT='2xx Response code'
+ echo '    [ OK ] 2xx Response code'
    [ OK ] 2xx Response code
+ ((  SMOKE_TESTS_RUN++  ))

I think this could be tweaked because incrementing 0 returns a 1 code which stops the script.

@asm89
Copy link
Owner

asm89 commented Mar 6, 2017

Good catch. I'm afraid smoke.sh isn't really set -e proof regardless as it relies on checking the exit code manually in various places as the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants