Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Add spell check to makefile to check for typos ticket#25024
- Use misspell to check for typos in codebase - Add `make check-typos` to run the checks - Add `check-typos` to `make check`
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @@ -97,7 +97,7 @@ doxygen: | ||
| test: all | ||
| $(top_builddir)/src/test/test | ||
|
|
||
| check-local: check-spaces check-changes | ||
| check-local: check-spaces check-changes check-typos | ||
This comment has been minimized.
This comment has been minimized.
fristonio
Author
|
||
|
|
||
| need-chutney-path: | ||
| @if test ! -d "$$CHUTNEY_PATH"; then \ | ||
| @@ -217,6 +217,26 @@ check-logs: | ||
| $(top_srcdir)/scripts/maint/checkLogs.pl \ | ||
| $(top_srcdir)/src/*/*.[ch] | sort -n | ||
|
|
||
| .PHONY: check-typos | ||
| check-typos: | ||
| @if test -x "`which misspell 2>&1;true`"; then \ | ||
| echo "Checking for Typos ..."; \ | ||
| (`which misspell` \ | ||
This comment has been minimized.
nmathewson
|
||
| $(top_srcdir)/src/**/*.[ch] \ | ||
This comment has been minimized.
nmathewson
|
||
| $(top_srcdir)/doc \ | ||
| $(top_srcdir)/contrib \ | ||
| $(top_srcdir)/scripts \ | ||
| $(top_srcdir)/README \ | ||
| $(top_srcdir)/ChangeLog \ | ||
| $(top_srcdir)/INSTALL \ | ||
| $(top_srcdir)/ReleaseNotes \ | ||
| $(top_srcdir)/LICENSE); \ | ||
| else \ | ||
| echo "Tor uses misspell to check for typos"; \ | ||
| echo "It seems that you don't have misspell installed."; \ | ||
| echo "Install the latest version of misspell from here https://github.com/client9/misspell#install"; \ | ||
| fi | ||
|
|
||
| .PHONY: check-changes | ||
| check-changes: | ||
| if USEPYTHON | ||
If I install 'misspell' and apply this patch, will it break Tor builds for now? If so, we shouldn't add it to check-local until it actually passes.