From 12fe3eb5590f081fc6cf76c4cc6813e0f7054792 Mon Sep 17 00:00:00 2001
From: Georgios Kalpakas <kalpakas.g@gmail.com>
Date: Fri, 12 May 2017 09:48:28 +0300
Subject: [PATCH] fix(aio): only register ServiceWorker in production mode

Since abb36e3cb, we no longer rely on the cli to set up ServiceWorker, but do it
manually as part of `yarn build`. When using `ng serve`, registering the
ServiceWorker fails, because we haven't created `ngsw-manifest.json` nor copied
`worker-basic.min.js` into dist.

This commit works around this, by only registering the service worker in
production mode (which is what the cli does too).

Caveat:
It is not possible to enable ServiceWorker with `ng serve`/`yarn start` and
using the `--prod` flag will try to register it, but fail because the necessary
files (`ngsw-manifest.json` and `worker-basic.min.js`) will not be available.
(As a work-around, you can use `yarn build` and serve the files in `dist/` with
`yarn http-server -- dist -p 4200`.)
---
 aio/README.md   | 14 +++++++++++++-
 aio/src/main.ts |  2 +-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/aio/README.md b/aio/README.md
index 565084645b408..cbf6dcfbdc27b 100644
--- a/aio/README.md
+++ b/aio/README.md
@@ -31,6 +31,18 @@ Here are the most important tasks you might need to use:
 * `yarn generate-zips` - generate the zip files from the examples. Zip available via the `live-example` tags in the docs.
 
 
+## Using ServiceWorker locally
+
+Since abb36e3cb, running `yarn start -- --prod` will no longer set up the ServiceWorker, which
+would require manually running `yarn sw-manifest` and `yarn sw-copy` (something that is not possible
+with webpack serving the files from memory).
+
+If you want to test ServiceWorker locally, you can use `yarn build` and serve the files in `dist/`
+with `yarn http-server -- dist -p 4200`.
+
+For more details see #16745.
+
+
 ## Guide to authoring
 
 There are two types of content in the documentatation:
@@ -56,7 +68,7 @@ extracting the documentation and generating JSON files that can be consumed by t
 
 Full doc generation can take up to one minute. That's too slow for efficient document creation and editing.
 
-You can make small changes in a smart editor that displays formatted markdown: 
+You can make small changes in a smart editor that displays formatted markdown:
 >In VS Code, _Cmd-K, V_ opens markdown preview in side pane; _Cmd-B_ toggles left sidebar
 
 You also want to see those changes displayed properly in the doc viewer
diff --git a/aio/src/main.ts b/aio/src/main.ts
index ffc069d943d91..40593a4b231c3 100644
--- a/aio/src/main.ts
+++ b/aio/src/main.ts
@@ -9,7 +9,7 @@ if (environment.production) {
 }
 
 platformBrowserDynamic().bootstrapModule(AppModule).then(ref => {
-  if ('serviceWorker' in (navigator as any)) {
+  if (environment.production && 'serviceWorker' in (navigator as any)) {
     const appRef: ApplicationRef = ref.injector.get(ApplicationRef);
     appRef.isStable.first().subscribe(() => {
       (navigator as any).serviceWorker.register('/worker-basic.min.js');