Many "unused imports" warning occurs

[ghost]

thank you for this great library.

v0.10.2

Like example below,

#[mockall::automock]
pub mod forms {
    use std::convert::TryInto;

    pub async fn hoge() -> Hoge {
        let row = sth...
        Ok(row.try_into()?)
    }
}

In this case, TryInto surely is used but warns unused imports. Not only this, but also like below.

#[mockall::automock]
pub mod forms {
    use crate::{a, b}; // <- b occurs unused imports
    use crate::hoge::somepubfunction; // <- occurs
}

I think this related to https://github.com/asomers/mockall/pull/54/files, but I can't find where to fix.

[asomers]

Please tell me what version of rustc you are using, and the exact warning you see.

[ghost]

❯ rustc --version
rustc 1.52.1 (9bc8c42bb 2021-05-09)

every warning is same

warning: unused import: `hoge`
 --> crates/~~~
  |
7 |     use crate::~~~hoge

[asomers]

I don't understand. What code corresponds to that warning? I was expecting to see something about TryInto.

[ghost]

Ok, I can't upload all codes here but it's like this.

#[mockall::automock]
pub mod Sth {
    use crate::somerecord;
    use crate::someerror;
	use crate::somepool;
    use std::convert::TryInto; // <- this causes unused imports warning.
    use uuid::Uuid;

    pub async fn find_by_id(id: Uuid) -> Result<somerecord, someerror> {
        let row = sqlx::query("SELECT * FROM sth WHERE id = $1::uuid")
            .bind(id)
            .fetch_one(somepool.get().unwrap())
            .await
            .map_err::<someerror, _>(Into::into)?;

        Ok(row.try_into()?)
    }
}

[asomers]

And that code produces what warning?

[ghost]

This one.

warning: unused import: TryInto
--> crates/~~~
|
7 | use std::convert::TryInto;

[asomers]

Should be easy to suppress. The generated mock module needs those imports, in case they're used by the mock functions' signatures. But in this case, they're only used by the bodies, so the import isn't used. Suppressing the warning in mockall is the correct solution.

[ghost]

Ah yes that's what I'm doing currently with allow unused_imports.

Thank you for replying. It will be great if that causes no warning without suppressing.

[asomers]

Reopening, because Mockall should suppress this warning itself.

[asomers]

@ulwlu could you please test your crate against the branch in the linked PR?

[ghost]

Sure, now I am working but will try in a day.

[ghost]

@asomers

I tried with the cargo.toml below, and all errors are gone! thx!!!

mockall = { git = "https://github.com/asomers/mockall", branch = "unused-warnings"}

[ghost]

@asomers

Hi do you plan to release this one in next version...?
I'm fine with this way of specifiying git url in Cargo.toml, but hopefully you can release next patch version soon.....

[asomers]

@ulwlu done!

[ghost]

Thank you very much!! And thank you for this great mocking library again.