Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .js input files via out_dir attribute #34

Merged
merged 2 commits into from May 6, 2022
Merged

Add support for .js input files via out_dir attribute #34

merged 2 commits into from May 6, 2022

Conversation

mdittmer
Copy link
Contributor

@mdittmer mdittmer commented May 5, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 5, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

alexeagle
alexeagle approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - thanks! Can you get the CI green?

swc/swc.bzl Outdated Show resolved Hide resolved
swc/private/swc.bzl Outdated Show resolved Hide resolved
@mdittmer
Clean up .js-as-input feature
5fa3ce5 
Touch up documentation and drop unnecessary temporary variable
@alexeagle alexeagle merged commit 245f582 into aspect-build:main May 6, 2022
@alexeagle
Copy link
Member

oops, I merged too soon it seems, main is red now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdittmer @CLAassistant @alexeagle